Skip to content

Commit b78fc88

Browse files
Fixed an issue in file dialog where rename was not working. #9651
1 parent caafc6b commit b78fc88

File tree

4 files changed

+13
-5
lines changed

4 files changed

+13
-5
lines changed

docs/en_US/release_notes_9_13.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,5 +41,7 @@ Bug fixes
4141
| `Issue #9486 <https://github.com/pgadmin-org/pgadmin4/issues/9486>`_ - Fixed an issue where column comments were not displayed in the SQL tab for materialised views.
4242
| `Issue #9572 <https://github.com/pgadmin-org/pgadmin4/issues/9572>`_ - Fix an issue where deployment of helm chart crashing with operation not permitted.
4343
| `Issue #9583 <https://github.com/pgadmin-org/pgadmin4/issues/9583>`_ - Fix translation compilation.
44+
| `Issue #9649 <https://github.com/pgadmin-org/pgadmin4/issues/9649>`_ - Fix broken checkbox selection in backup dialog objects tree.
45+
| `Issue #9651 <https://github.com/pgadmin-org/pgadmin4/issues/9651>`_ - Fixed an issue in file dialog where rename was not working.
4446
4547

web/pgadmin/misc/file_manager/static/js/components/ListView.jsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,13 +131,15 @@ const columns = [
131131
];
132132

133133

134-
export default function ListView({items, operation, ...props}) {
134+
export default function ListView({items, operation, onItemEnter, ...props}) {
135135
const gridRef = useRef();
136136

137137
useEffect(()=>{
138138
if(operation.type) {
139139
operation.type == 'add' && gridRef.current.scrollToCell({rowIdx: operation.idx});
140-
gridRef.current.selectCell({idx: 0, rowIdx: operation.idx}, true);
140+
gridRef.current.selectCell({idx: 0, rowIdx: operation.idx}, {
141+
enableEditor: true
142+
});
141143
}
142144
}, [operation]);
143145

@@ -171,6 +173,10 @@ export default function ListView({items, operation, ...props}) {
171173
noRowsText={gettext('No files/folders found')}
172174
onRowsChange={onRowsChange}
173175
onCellKeyDown={onCellKeyDown}
176+
onItemEnter={(row, e)=>{
177+
e.preventGridDefault();
178+
onItemEnter(row);
179+
}}
174180
{...props}
175181
/>
176182
);

web/pgadmin/static/js/components/PgReactDataGrid.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,15 +109,15 @@ export function CustomRow({inTest=false, ...props}) {
109109
}
110110

111111
const onCellClick = (args) => {
112-
gridUtils.onItemClick?.(args.row.rowIdx);
112+
gridUtils.onItemClick?.(args.rowIdx);
113113
props.onRowClick?.(args.row);
114114
};
115115

116116
const onCellDoubleClick = (args, e) => {
117117
// check if grid default is prevented.
118118
props.onCellDoubleClick?.(args, e);
119119
if(e.isGridDefaultPrevented()) return;
120-
gridUtils.onItemEnter?.(args.row);
120+
gridUtils.onItemEnter?.(args.row, e);
121121
};
122122

123123
return (

web/regression/requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
# relevant packages.
2323
###########################################################
2424
extras==1.0.0
25-
fixtures==4.3.0
25+
fixtures==4.3.1
2626
linecache2==1.0.0
2727
pbr==7.0.3
2828
pycodestyle>=2.5.0

0 commit comments

Comments
 (0)