Add Directory in pgAdmin4 Object Explorer.#8496
Merged
akshay-joshi merged 1 commit intopgadmin-org:masterfrom Mar 3, 2025
Merged
Add Directory in pgAdmin4 Object Explorer.#8496akshay-joshi merged 1 commit intopgadmin-org:masterfrom
akshay-joshi merged 1 commit intopgadmin-org:masterfrom
Conversation
akshay-joshi
requested changes
Feb 27, 2025
Contributor
akshay-joshi
left a comment
There was a problem hiding this comment.
- Create Script throwing a syntax error, select any existing directory, right-click, and click 'Create Script'. Run the script. Check the SQL panel also after the fix.
- The "-- Drop Directory " comment is missing in the SQL tab and Create Script.
- The Security Tab is visible from EPAS 17 then for lesser versions it should not be visible in the Properties Panel (near Dashboards).
- EPAS 17- Grant Read and Write Privileges to 2 different users respectively. Select that directory and check the Properties panel, Privileges are showing empty.
- Take all the screenshots again as all the borders should be visible.
- Why there are two files "alter.sql" and "update.sql"? Some SQL's are identical there, please merge the logic into one if possible.
- Replace PPAS with EPAS in the string "are not supported by PPAS" in all the files of the entire project.
web/pgadmin/browser/server_groups/servers/directories/__init__.py
Outdated
Show resolved
Hide resolved
web/pgadmin/browser/server_groups/servers/directories/tests/utils.py
Outdated
Show resolved
Hide resolved
web/pgadmin/browser/server_groups/servers/directories/tests/utils.py
Outdated
Show resolved
Hide resolved
web/pgadmin/browser/server_groups/servers/directories/tests/test_directories_get.py
Outdated
Show resolved
Hide resolved
web/pgadmin/browser/server_groups/servers/directories/tests/utils.py
Outdated
Show resolved
Hide resolved
web/pgadmin/browser/server_groups/servers/directories/tests/utils.py
Outdated
Show resolved
Hide resolved
7fff656 to
4997f9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detail Info:- #8034