Add option to load/replace servers.json every boot#8519
Merged
akshay-joshi merged 5 commits intopgadmin-org:masterfrom Mar 11, 2025
Merged
Conversation
|
Uh, nice 😄 We could use this. We are forced to use some sort of IoC db row seeding solution at the moment. |
yogeshmahajan-1903
suggested changes
Mar 10, 2025
Contributor
yogeshmahajan-1903
left a comment
yogeshmahajan-1903
left a comment
There was a problem hiding this comment.
Please update documentation for the same here.
Contributor
Author
I tried adding some documentation below the PGADMIN_SERVER_JSON_FILE definition, as it seems related. I dont know if it should be moved? |
yogeshmahajan-1903
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
This PR adds the env
PGADMIN_REPLACE_SERVERS_ON_STARTUPdo the Docker image.If this env is set to true, the servers.json will be loaded on every container boot, with the
--replaceoption.The motivation for this change is to be able to define servers as part of the deployments / infrastructure as code instead of manually manipulating the pgadmin database state.
This should not introduce any breaking change, and will only differ in execution if
PGADMIN_REPLACE_SERVERS_ON_STARTUPis set to true.I have tested the image locally, with both
PGADMIN_REPLACE_SERVERS_ON_STARTUPundefined and with it set to true. I have also tested both cases on an initialized database and on a non-initialized database.