Skip to content

Ability to configure font family in SQL editors #8553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityatoshniwal merged 1 commit into from
Mar 24, 2025
Merged

Ability to configure font family in SQL editors #8553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified docs/en_US/images/preferences_sql_editor.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions docs/en_US/preferences.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,10 @@ Use the fields on the *Editor* panel to change settings of the query editor.
* When the *Code folding?* switch is set to *False*, the editor will disable
code folding. Disabling will improve editor performance with large files.

* Use the *Font family* field to specify the font family that will be used in
all SQL text boxes and editors. If the font is not found, the default font
of *Source Code Pro* will be used.

* Use the *Font size* field to specify the font size that will be used in text
boxes and editors.

Expand Down
3 changes: 2 additions & 1 deletion web/pgadmin/static/js/components/ReactCodeMirror/components/Editor.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,9 @@ export default function Editor({

const fontSize = calcFontSize(pref.sql_font_size);
newConfigExtn.push(EditorView.theme({
'.cm-content': {
'& .cm-content': {
fontSize: fontSize,
fontFamily: pref.sql_font_family,
},
'.cm-gutters': {
fontSize: fontSize,
Expand Down
12 changes: 12 additions & 0 deletions web/pgadmin/tools/sqleditor/utils/query_tool_preferences.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,18 @@ def register_query_tool_preferences(self):
)
)

self.sql_font_family = self.preference.register(
'Editor', 'sql_font_family',
gettext("Font family"), 'text', 'Source Code Pro',
category_label=PREF_LABEL_DISPLAY,
help_str=gettext(
'Specify the font family to be used for all SQL editors. '
'The specified font should already be installed on your system. '
'If the font is not found, the editor will fall back to the '
'default font, Source Code Pro.'
)
)

self.display_connection_status = self.preference.register(
'display', 'connection_status',
gettext("Connection status"), 'boolean', True,
Expand Down
Loading