Skip to content

Open user management in a tab instead of dialog for better UI/UX. #8574#8578

Merged
akshay-joshi merged 2 commits intopgadmin-org:masterfrom
adityatoshniwal:8574-user-management
Mar 25, 2025
Merged

Open user management in a tab instead of dialog for better UI/UX. #8574#8578
akshay-joshi merged 2 commits intopgadmin-org:masterfrom
adityatoshniwal:8574-user-management

Conversation

@adityatoshniwal
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@akshay-joshi akshay-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GUI Review Comments:

  1. The email field should be disabled for the currently logged-in user, as the email should not be updated.
  2. Active and Locked should be toggle control instead of the 'Yes/No' text in the cell, as for consistency with other places.
  3. New Password and Confirm Password should be disabled for other than 'internal' mode.
  4. If the username is not allowed to modify then make it disabled, this behavior is present in the old logic as well, but we need to fix.
  5. Do we need a refresh button as creating/deleting the users is instant?
  6. Change ownership dialog showing "undefined shared server owned by this user" it should show the count of the shared server.

@adityatoshniwal
Copy link
Copy Markdown
Contributor Author

GUI Review Comments:

  1. The email field should be disabled for the currently logged-in user, as the email should not be updated.
  2. Active and Locked should be toggle control instead of the 'Yes/No' text in the cell, as for consistency with other places.
  3. New Password and Confirm Password should be disabled for other than 'internal' mode.
  4. If the username is not allowed to modify then make it disabled, this behavior is present in the old logic as well, but we need to fix.
  5. Do we need a refresh button as creating/deleting the users is instant?

There can be multiple admins which many change users. As it is a tab which can remain open for a long time, its good to have a refresh button.

  1. Change ownership dialog showing "undefined shared server owned by this user" it should show the count of the shared server.

All other issues are fixed.

@akshay-joshi akshay-joshi merged commit 9ab451e into pgadmin-org:master Mar 25, 2025
27 of 32 checks passed
@adityatoshniwal adityatoshniwal deleted the 8574-user-management branch May 14, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants