Open user management in a tab instead of dialog for better UI/UX. #8574#8578
Merged
akshay-joshi merged 2 commits intopgadmin-org:masterfrom Mar 25, 2025
Merged
Conversation
52e6620 to
056082e
Compare
akshay-joshi
requested changes
Mar 21, 2025
Contributor
akshay-joshi
left a comment
There was a problem hiding this comment.
GUI Review Comments:
- The email field should be disabled for the currently logged-in user, as the email should not be updated.
- Active and Locked should be toggle control instead of the 'Yes/No' text in the cell, as for consistency with other places.
- New Password and Confirm Password should be disabled for other than 'internal' mode.
- If the username is not allowed to modify then make it disabled, this behavior is present in the old logic as well, but we need to fix.
- Do we need a refresh button as creating/deleting the users is instant?
- Change ownership dialog showing "undefined shared server owned by this user" it should show the count of the shared server.
056082e to
59d9b65
Compare
59d9b65 to
707fe4d
Compare
Contributor
Author
There can be multiple admins which many change users. As it is a tab which can remain open for a long time, its good to have a refresh button.
All other issues are fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.