Skip to content

Fixed an issue where the upgrade_check API returned an unexpected key… #8586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshay-joshi merged 4 commits into from
Mar 25, 2025
Merged

Fixed an issue where the upgrade_check API returned an unexpected key… #8586

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3037f25
Fixed an issue where the upgrade_check API returned an unexpected key…
anilsahoo20 Mar 24, 2025
1853d14
Optimized the code to not use the urlopen_with_ssl function
anilsahoo20 Mar 24, 2025
dfaca69
Fixed pep8 issues
anilsahoo20 Mar 24, 2025
3c5e9f4
urlopen_with_ssl function removed
anilsahoo20 Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions web/pgadmin/misc/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
import time
import json
import os
import sys
import ssl
from urllib.request import urlopen
from pgadmin.settings import get_setting, store_setting

Expand Down Expand Up @@ -345,8 +347,16 @@ def upgrade_check():
# Do not wait for more than 5 seconds.
# It stuck on rendering the browser.html, while working in the
# broken network.
if os.path.exists(config.CA_FILE):
response = urlopen(url, data, 5, cafile=config.CA_FILE)
if os.path.exists(config.CA_FILE) and sys.version_info >= (
3, 13):
# Use SSL context for Python 3.13+
context = ssl.create_default_context(cafile=config.CA_FILE)
response = urlopen(url, data=data, timeout=5,
context=context)
elif os.path.exists(config.CA_FILE):
# Use cafile parameter for older versions
response = urlopen(url, data=data, timeout=5,
cafile=config.CA_FILE)
else:
response = urlopen(url, data, 5)
current_app.logger.debug(
Expand Down
Loading