Configurable ligature support#8626
Merged
akshay-joshi merged 1 commit intopgadmin-org:masterfrom Apr 3, 2025
Merged
Conversation
MikeChristensen
commented
Apr 2, 2025
MikeChristensen
force-pushed
the
LigatureSupport
branch
from
adfec3f to
7c9e76d
Compare
adityatoshniwal
approved these changes
Apr 3, 2025
Contributor
|
I've created #8629 for tracking this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that fonts are configurable in the SQL editor, why not ignite one of the most controversial debates in the programming community since tabs vs. spaces. That's right, it's coding ligatures in the code editor.
I'll admit I'm a big fan of ligatures and enable them in any IDE that supports them (terminal emulators like Warp and Ghostty, IDEs like VSCode and Rider, and text editors such as Sublime - in my world they all have ligatures). However, I'll admit they might be a bit annoying in SQL. Then it occurred to me, pgAdmin is not just about SQL. It's also used for languages supported by Postgres functions written in pgSQL, PERL, Python as well as all the crazy extensions people have created such as Javascript (V8). There's even pl/Rust because of course there is.
This PR enables ligature support in the SQL editor, but the feature is disabled by default so ligature enthusiasts such as myself will have to go looking for it.
No biggie if this doesn't make it into 9.2, and I'm open to any comments or feedback.
Enabled Ligatures
Disabled Ligatures