Closed
Conversation
fix bash path formally
Not Linux. fix shebang form.
for all unixen
Contributor
|
Please fix the Python code style. |
khushboovashi
requested changes
Apr 21, 2025
| @@ -1,4 +1,4 @@ | |||
| #!/bin/bash | |||
| #!/usr/bin/env bash | |||
Contributor
There was a problem hiding this comment.
What is the reason for this proposed change?
| config.EFFECTIVE_SERVER_PORT) | ||
| ) | ||
| sys.stdout.flush() | ||
| webbrowser.open(f"http://{config.DEFAULT_SERVER}:{config.EFFECTIVE_SERVER_PORT}") |
Contributor
There was a problem hiding this comment.
The URL is already prepared in the previous line, so you can prepare it using a variable and use it in both places.
Contributor
|
Closing the PR due to no response from the author since April 21st. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change "/bin/bash" -> "/usr/bin/env bash"