Ensure worspaces/pgadmin state is saved on abrupt shutdown of pgadmin.#GH_3319#8671
Conversation
ae9bd5f to
7441c9e
Compare
c2980a1 to
2b23a35
Compare
akshay-joshi
left a comment
There was a problem hiding this comment.
GUI Review Comments:
-
When opening pgAdmin again in the browser Default Workspace should be in focus. Open Schema Diff tool and refresh the browser.
-
PSQL tools database name not showing in the single line on reopening pgAdmin.
-
Delete all the states from the table if the user changes the preferences and sets them to False.
-
Getting error AttributeError: 'NoneType' object has no attribute 'connection' in line 604, in _get_database_role psql/init.py
-
params['db'] = underscore_escape(data['db_name']) TypeError: 'NoneType' object is not subscriptable in line 104 in psql/init.py
-
Open Query Tool/PSQL in the respective workspace and then refresh the browser. It opens in the Default workspace, which seems to be correct, but we need to document this behaviour.
-
Query Tool/PSQL for adHoc servers are still opening with error. We should not store state of the adHoc server.
-
The show_query_tool.js, show_erd_tool.js, showSchemaDiffTool.js and show_psql_tool.js files have duplicate code to open the respective tools. We can easily make some part of the logic generic.
-
Why file name 'showSchemaDiffTool.js' different in respect to others like show_query_tool.js
-
Documentation/Screenshot updates are missing for Preferences.
-
Create a new .rst file to explain this new feature.
-
Add comments in the new function added in this PR and wherever needed in the code, so that others can understand the logic.
adityatoshniwal
left a comment
There was a problem hiding this comment.
Have we handled the case where a server is removed?
adityatoshniwal
left a comment
There was a problem hiding this comment.
Last time I had asked if the connection was removed. Open query tool, disconnect server, remove the server and close the query tool.
Also, what happens to open files?
f9245e4 to
e318d8c
Compare
fbb8c28 to
c7f294c
Compare
9b38019 to
13d2553
Compare
13d2553 to
fc5d9ce
Compare
No description provided.