Skip to content

Read password from PassFile when connecting. #9810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m000 wants to merge 4 commits into
base: master
Choose a base branch
from
+16 −10
Open

Read password from PassFile when connecting. #9810

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c9be2d
Read password from PassFile when connecting.
m000 Apr 1, 2026
5db808c
Revert "Read password from PassFile when connecting."
m000 Apr 2, 2026
c1ffe0d
Clarify passfile logic in Connection::connect().
m000 Apr 2, 2026
ba2ce6c
Merge branch 'master' into passfile-fix
m000 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions web/pgadmin/utils/driver/psycopg3/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
import secrets
import datetime
import asyncio
import copy
from collections import deque
import psycopg
from flask import g, current_app
Expand Down Expand Up @@ -281,7 +280,6 @@ def connect(self, **kwargs):
password, encpass, is_update_password = \
self._check_user_password(kwargs)

passfile = kwargs['passfile'] if 'passfile' in kwargs else None
tunnel_password = kwargs['tunnel_password'] if 'tunnel_password' in \
kwargs else ''

Expand Down Expand Up @@ -313,14 +311,22 @@ def connect(self, **kwargs):
if is_error:
return False, errmsg

# If no password credential is found then connect request might
# come from Query tool, ViewData grid, debugger etc tools.
# we will check for pgpass file availability from connection manager
# if it's present then we will use it
if not password and not encpass and not passfile:
passfile = manager.get_connection_param_value('passfile')
if manager.passexec:
password = manager.passexec.get()
# If no password credential is found then connect request might come
# from Query tool, ViewData grid, debugger, etc. In that case, fall
# back to using the password returned from manager.passexec.
passfile = manager.get_connection_param_value('passfile')
if not password and not encpass and not passfile and manager.passexec:
password = manager.passexec.get()

# create_connection_string() automatically picks up the passfile from
# connection parameters. Warn if that differs from the passfile kwarg.
passfile_kwarg = kwargs.get('passfile', None)
if passfile_kwarg and passfile_kwarg != passfile:
current_app.logger.warning(
"Using the first of two specified passfiles: {!r}, {!r}".format(
passfile, passfile_kwarg
)
)

try:
database = self.db
Expand Down