issue 9656: for debian platform use absolute paths for a2enmod, a2enc…#9815
issue 9656: for debian platform use absolute paths for a2enmod, a2enc…#9815asheshv merged 1 commit intopgadmin-org:masterfrom
Conversation
…onf in pkg/linux/setup-web.sh (installed: usr/pgadmin4/bin/setup-web.sh) Reason: debian does not have /usr/sbin which contains a2enmod and a2enconf in the path environment variable anymore. This is the case for debian13 (trixie) and before
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughCommands in a Debian/Ubuntu setup script were modified to invoke Apache module and configuration management executables via absolute paths ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Looks good to me. |
fix for issue 9656: for debian platform use absolute paths for a2enmod, a2enconf in pkg/linux/setup-web.sh (installed: usr/pgadmin4/bin/setup-web.sh)
Reason: debian does not have /usr/sbin which contains a2enmod and a2enconf in the path environment variable anymore. This is the case for debian13 (trixie, released 2025-08-09) and before, I am not sure since which release
Applies to Updated version for release v9.14
Thank you anilsahoo20 and akshay-joshi for answering to the issue 9656 I raised. I am glad to finally submit this PR.
Summary by CodeRabbit
Bug Fixes