Skip to content

issue 9656: for debian platform use absolute paths for a2enmod, a2enc…#9815

Merged
asheshv merged 1 commit intopgadmin-org:masterfrom
rztrainlocal:master
Apr 6, 2026
Merged

issue 9656: for debian platform use absolute paths for a2enmod, a2enc…#9815
asheshv merged 1 commit intopgadmin-org:masterfrom
rztrainlocal:master

Conversation

@rztrainlocal
Copy link
Copy Markdown
Contributor

@rztrainlocal rztrainlocal commented Apr 3, 2026

fix for issue 9656: for debian platform use absolute paths for a2enmod, a2enconf in pkg/linux/setup-web.sh (installed: usr/pgadmin4/bin/setup-web.sh)

Reason: debian does not have /usr/sbin which contains a2enmod and a2enconf in the path environment variable anymore. This is the case for debian13 (trixie, released 2025-08-09) and before, I am not sure since which release

Applies to Updated version for release v9.14

Thank you anilsahoo20 and akshay-joshi for answering to the issue 9656 I raised. I am glad to finally submit this PR.

Summary by CodeRabbit

Bug Fixes

  • Improved the Debian/Ubuntu setup script to more reliably locate Apache configuration commands during the installation process.

…onf in pkg/linux/setup-web.sh (installed: usr/pgadmin4/bin/setup-web.sh)

Reason: debian does not have /usr/sbin which contains a2enmod and a2enconf in the path environment variable anymore. This is the case for debian13 (trixie) and before
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4c9333cf-c529-404b-96b2-ac1c81e582d1

📥 Commits

Reviewing files that changed from the base of the PR and between d8a078a and 8eb4616.

📒 Files selected for processing (1)
  • pkg/linux/setup-web.sh

Walkthrough

Commands in a Debian/Ubuntu setup script were modified to invoke Apache module and configuration management executables via absolute paths (/usr/sbin/a2enmod, /usr/sbin/a2enconf) rather than relying on the PATH environment variable. No control flow or error handling logic was altered.

Changes

Cohort / File(s) Summary
Apache Module and Configuration Management
pkg/linux/setup-web.sh
Updated a2enmod and a2enconf command invocations to use absolute paths (/usr/sbin/) instead of PATH-based resolution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly references issue 9656 and clearly describes the main change: using absolute paths for a2enmod and a2enconf on Debian platforms in the setup-web.sh script.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@asheshv
Copy link
Copy Markdown
Contributor

asheshv commented Apr 6, 2026

Looks good to me.

@asheshv asheshv merged commit d59fcf3 into pgadmin-org:master Apr 6, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants