Conversation
Update Python dependencies: - google-auth-oauthlib 1.3.0 → 1.3.1 - sphinxcontrib-youtube 1.4.1 → 1.5.0 - fixtures 4.3.1 → 4.3.2 - Add missing newline at end of requirements files Update JavaScript dependencies: - Replace deprecated @babel/plugin-proposal-* packages with @babel/plugin-transform-* equivalents - Remove unused @types/classnames dependency - Update yarn.lock Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughUpdate dependency pins (Python and tooling), replace Babel proposal plugins with transform equivalents in web build and lint configs, adjust web package.json, and add a PostGIS matrix dimension with parameterized package selection in GitHub Actions. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
EPAS 18 ships with edb-as18-postgis35 instead of postgis34. Add a postgisver matrix variable to support mixed versions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/run-python-tests-epas.yml:
- Around line 36-39: The matrix.include entry does not override the base matrix
so the invalid combination pgver: 18 + postgisver: 34 remains and include items
lack matrix.os; fix by either adding an explicit matrix.exclude entry for
{pgver: 18, postgisver: 34} to remove that invalid combo or by changing the base
lists so postgisver: 34 is not listed for pgver 18, and update every
matrix.include object to include os (so matrix.os is defined for runs-on: ${{
matrix.os }}); reference the matrix keys (matrix.include, pgver, postgisver,
matrix.os) and ensure the exclude or corrected include removes the
edb-as18-postgis34 request.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d813ac47-f376-4708-9dd5-6043aefb5fd1
📒 Files selected for processing (1)
.github/workflows/run-python-tests-epas.yml
The previous include entry for pgver 18 with postgisver 35 did not match any existing matrix combination (postgisver 34 != 35), so GitHub Actions created a new entry without an os value, causing runs-on to evaluate to ''. Use exclude to remove pgver 18 / postgisver 34 combos, then include with explicit os to re-add them with postgisver 35.
Summary
google-auth-oauthlib1.3.0 → 1.3.1,sphinxcontrib-youtube1.4.1 → 1.5.0,fixtures4.3.1 → 4.3.2, and fix missing newlines at EOF@babel/plugin-proposal-*packages with their@babel/plugin-transform-*equivalents@types/classnamesdependencySummary by CodeRabbit