fix: Bump runtime dependencies and upgrade ESLint to v10#9834
Conversation
- electron: 41.0.2 → 41.2.0 - eslint: ^9.39.2 → ^10.2.0 - axios: ^1.13.5 → ^1.15.0 - electron-context-menu: ^4.1.0 → ^4.1.2 - Added @eslint/js and globals as explicit devDependencies (required by ESLint 10) - Fixed no-useless-assignment lint errors in downloader.js and misc.js
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
WalkthroughThe pull request updates project dependencies across runtime and web package manifests, bumping versions for electron, eslint, axios, and other packages. Additionally, minor code refactoring is applied to the runtime downloader and utilities modules, including variable initialization and control flow simplification without altering functionality. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
@eslint/jsandglobalsas explicit devDependencies (required by ESLint 10, previously bundled)no-useless-assignmentlint errors indownloader.jsandmisc.js(new rule enabled by default in ESLint 10)Test plan
yarn run linterpasses with zero errorsmake bundle-devbuilds successfullycd runtime && yarn start— verify app launches and behaves normallySummary by CodeRabbit
Chores
Refactor