Skip to content

fix: Bump runtime dependencies and upgrade ESLint to v10#9834

Merged
asheshv merged 1 commit intomasterfrom
bump/runtime-deps
Apr 9, 2026
Merged

fix: Bump runtime dependencies and upgrade ESLint to v10#9834
asheshv merged 1 commit intomasterfrom
bump/runtime-deps

Conversation

@asheshv
Copy link
Copy Markdown
Contributor

@asheshv asheshv commented Apr 9, 2026

Summary

  • electron: 41.0.2 → 41.2.0
  • eslint: ^9.39.2 → ^10.2.0 (major upgrade)
  • axios: ^1.13.5 → ^1.15.0
  • electron-context-menu: ^4.1.0 → ^4.1.2
  • Added @eslint/js and globals as explicit devDependencies (required by ESLint 10, previously bundled)
  • Fixed no-useless-assignment lint errors in downloader.js and misc.js (new rule enabled by default in ESLint 10)

Test plan

  • yarn run linter passes with zero errors
  • make bundle-dev builds successfully
  • Manual smoke test: cd runtime && yarn start — verify app launches and behaves normally

Summary by CodeRabbit

  • Chores

    • Updated core runtime dependencies to latest stable versions, including Electron, ESLint, and HTTP client library
    • Added development tooling dependencies for enhanced code quality
  • Refactor

    • Improved internal code structure and error handling logic for better reliability and maintainability

- electron: 41.0.2 → 41.2.0
- eslint: ^9.39.2 → ^10.2.0
- axios: ^1.13.5 → ^1.15.0
- electron-context-menu: ^4.1.0 → ^4.1.2
- Added @eslint/js and globals as explicit devDependencies (required by ESLint 10)
- Fixed no-useless-assignment lint errors in downloader.js and misc.js
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fa71f575-01ec-4169-9182-8c144e12c7f7

📥 Commits

Reviewing files that changed from the base of the PR and between 9a76ed8 and 5862d35.

⛔ Files ignored due to path filters (1)
  • runtime/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (4)
  • runtime/package.json
  • runtime/src/js/downloader.js
  • runtime/src/js/misc.js
  • web/package.json

Walkthrough

The pull request updates project dependencies across runtime and web package manifests, bumping versions for electron, eslint, axios, and other packages. Additionally, minor code refactoring is applied to the runtime downloader and utilities modules, including variable initialization and control flow simplification without altering functionality.

Changes

Cohort / File(s) Summary
Runtime Dependencies
runtime/package.json
Updated electron (41.0.2 → 41.2.0), eslint (^9.39.2 → ^10.2.0), axios (^1.13.5 → ^1.15.0), electron-context-menu (^4.1.0 → ^4.1.2). Added @eslint/js and globals to devDependencies.
Web Dependencies
web/package.json
Removed and re-added @babel/preset-react (^7.27.1) entry in devDependencies.
Runtime Code Refactoring
runtime/src/js/downloader.js, runtime/src/js/misc.js
Changed progress variable from initialized to uninitialized in updateProgress(). Simplified readServerLog() control flow by removing unused variable and converting explicit else block to fallthrough logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: dependency version bumps and ESLint upgrade to v10, which is the primary objective of the PR.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump/runtime-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@asheshv asheshv merged commit a3a0537 into master Apr 9, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant