Skip to content

chore(regression): remove dead test_advanced_config + Greenplum config gitignore #9949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpage wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −511
Open

chore(regression): remove dead test_advanced_config + Greenplum config gitignore #9949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions web/regression/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
parent_id.pkl
regression.log
test_greenplum_config.json
test_advanced_config.json
test_config.json
test_result.json
screenshots/
25 changes: 8 additions & 17 deletions web/regression/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,24 +55,21 @@ General Information
3. test_server_get.py
4. test_server_update.py

2) The pgAdmin4 source tree includes 2 different configuration file templates.
One file template for the server configuration
named ‘test_config.json.in' and another for test configuration named
'test_advanced_config.json.in' in the ‘pgAdmin4/web/regression’ directory.
After completing the pgAdmin4 configuration, you must make a working copy of
the templates called test_config.json and test_advance_config.json
before modifying the file contents.
2) The pgAdmin4 source tree includes a configuration file template for the
server configuration named 'test_config.json.in' in the
'pgAdmin4/web/regression' directory. After completing the pgAdmin4
configuration, you must make a working copy of the template called
test_config.json before modifying the file contents.

2a) The following command copies the test_config.json.in file, creating a
configuration file named test_config.json (same way user can copy
test_advance_config.json.in file into test_advance_config.json)
configuration file named test_config.json:

$ cp pgadmin4/web/regression/test_config.json.in \
pgadmin4/web/regression/test_config.json

2b) After creating the server and test configuration file, add (or modify)
2b) After creating the server configuration file, add (or modify)
parameter values as per requirements. The pgAdmin4 regression framework
expects to find the files in the directory
expects to find the file in the directory
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix the extra whitespace in the sentence.

Line 72 contains a double space: "expects to find the file in the directory" which appears to be a leftover from editing. The sentence should have a single space.

📝 Proposed fix 
-        expects to find the file in the  directory
+        expects to find the file in the directory
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
expects to find the file in the directory
expects to find the file in the directory
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@web/regression/README.md` at line 72, Update the sentence "expects to find
the file in the  directory" to remove the double space between "the" and
"directory" so it reads "expects to find the file in the directory"; locate the
string in web/regression/README.md (the line containing "expects to find the
file in the  directory") and replace the two spaces with a single space.

'/<installation dir>/web/regression/'. If you move the file to another
location, you must create a symbolic link that specifies the new location.

Expand All @@ -82,12 +79,6 @@ General Information
test_config file is in JSON format and property values are
case-sensitive.

2d) Specifying the Test Configuration file:

The user can add/change test data as per their need. The
test_advanced_config file is in JSON format and property values are
case-sensitive.


Test Data Details
-----------------
Expand Down
Loading
Loading