chore(deps): bump cryptography 47.0.* -> 48.0.*#9960
Merged
Conversation
Supersedes dependabot #9926 (and its /web/regression duplicate #9932). Inherited via `-r ../../requirements.txt`, so the single edit covers both. cryptography 48 is a smaller bump than its major-version label suggests: - Removed Python 3.8 support. pgAdmin requires Python 3.9+ across the supported platforms, so this is a no-op for us. (3.9.0 and 3.9.1 specifically are excluded by the new metadata; nothing in pgAdmin's CI / packaging runs those exact patch versions.) - Stricter X.509 CRL parsing: a CRL whose inner `TBSCertList.signature` does not match the outer `signatureAlgorithm` now raises `ValueError` instead of being parsed and rejected later during signature verification. - Added ML-KEM and ML-DSA post-quantum primitives (additive). pgAdmin's cryptography surface area is narrow and CRL-free: - web/pgadmin/settings/__init__.py Fernet - web/pgadmin/utils/session.py Fernet, hashes, HKDF - web/pgadmin/utils/crypto.py Cipher, AES, CFB8 No imports of `cryptography.x509`, `CertificateRevocationList`, or `load_pem_x509_crl` anywhere in the tree, so the stricter CRL parsing in 48 cannot affect pgAdmin. The OpenSSL 1.1.x / LibreSSL < 4.1 removal that I initially flagged as a concern actually happened in cryptography 47, which master is already on. No platform-support regression from this bump.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe pull request updates the ChangesCryptography Dependency Update
🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes dependabot #9926 (and its
/web/regressionduplicate #9932 — that file inherits via-r ../../requirements.txt, so the single edit covers both).Why this is safe — short version
cryptography 48 is a smaller bump than the major-version label suggests, and none of its breaking changes touch pgAdmin's usage.
Documented breaking changes in 48.0.0
requires_pythonnow excludes 3.9.0 and 3.9.1 specifically. Nothing in pgAdmin's CI or packaging targets those exact patch versions (3.9.0 = Sep 2020, 3.9.1 = Dec 2020).TBSCertList.signaturedoesn't match the outersignatureAlgorithmnow raisesValueErrorinstead of being parsed and rejected later during signature verification.pgAdmin's
cryptographysurface areaNo imports of
cryptography.x509,CertificateRevocationList, orload_pem_x509_crlanywhere in the tree. The stricter CRL parsing in 48 cannot affect pgAdmin.About the OpenSSL 1.1.x removal
I initially flagged "drops OpenSSL 1.1.x" as a concern, but on closer reading of the changelog that happened in cryptography 47, which master is already on. No new platform-support regression from this bump.
Test plan
requirements.txt:25grepconfirms nox509/ CRL usage anywhere in the treeSupersedes
Summary by CodeRabbit