Skip to content

Commit 1bb2748

Browse files
committed
Merge branch 'DBTOOLS-2020_fix_auto_formatting' into 'master'
DBTOOLS-2020 fixed auto formatting See merge request codekeeper/pgcodekeeper-core!240
2 parents 78cd977 + 903670c commit 1bb2748

4 files changed

Lines changed: 24 additions & 7 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
2424
- Fixed monitor progress tracking.
2525
- Fixed a bug in the generation of the migration script when data migration when recreating tables with serial-type fields for PostgreSQL.
2626
- Fixed a bug with searching for dependencies for the LATERAL function in PostgreSQL.
27+
- Fixed a bug with automatic object code formatting.
2728

2829
## [14.0.0] - 2026-02-25
2930

CHANGELOG.ru.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
- Исправлено отслеживание прогресса в мониторах.
2525
- Исправлена ошибка в генерации скрипта миграции при переливке данных при пересоздании таблиц с полями типа serial в PostgreSQL.
2626
- Исправлена ошибка с поиском зависимостей для LATERAL функции в PostgreSQL.
27+
- Исправлена ошибка автоматического форматирования кода объектов.
2728

2829
## [14.0.0] - 2026-02-25
2930

src/main/java/org/pgcodekeeper/core/database/base/project/AbstractModelExporter.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,14 +107,17 @@ protected AbstractModelExporter(Path outDir, IDatabase db, String sqlEncoding, I
107107
protected AbstractModelExporter(Path outDir, IDatabase newDb, IDatabase oldDb,
108108
Collection<TreeElement> changedObjects,
109109
String sqlEncoding, ISettings settings) {
110+
// we should create new settings to get correct script in project files
111+
var set = new CoreSettings();
112+
set.setFormatConfiguration(settings.getFormatConfiguration());
113+
set.setAutoFormatObjectCode(settings.isAutoFormatObjectCode());
114+
110115
this.outDir = outDir;
111116
this.newDb = newDb;
112117
this.oldDb = oldDb;
113118
this.sqlEncoding = sqlEncoding;
114119
this.changeList = changedObjects;
115-
116-
// we should create new settings to get correct script in project files
117-
this.settings = new CoreSettings();
120+
this.settings = set;
118121
}
119122

120123
/**

src/main/java/org/pgcodekeeper/core/settings/CoreSettings.java

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
package org.pgcodekeeper.core.settings;
1717

1818
import org.pgcodekeeper.core.Consts;
19-
import org.pgcodekeeper.core.database.base.formatter.FormatConfiguration;
19+
import org.pgcodekeeper.core.database.api.formatter.IFormatConfiguration;
2020
import org.pgcodekeeper.core.database.api.schema.DbObjType;
2121

2222
import java.util.ArrayList;
@@ -51,6 +51,8 @@ public class CoreSettings implements ISettings {
5151
private boolean ignoreConcurrentModification;
5252
private boolean parallelLoad;
5353
private boolean disableAutoLoad;
54+
private IFormatConfiguration formatConfiguration;
55+
private boolean isAutoFormatObjectCode;
5456

5557
private String timeZone;
5658
private String clusterName;
@@ -134,7 +136,11 @@ public void setCommentsToEnd(boolean commentsToEnd) {
134136

135137
@Override
136138
public boolean isAutoFormatObjectCode() {
137-
return false;
139+
return isAutoFormatObjectCode;
140+
}
141+
142+
public void setAutoFormatObjectCode(boolean isAutoFormatObjectCode) {
143+
this.isAutoFormatObjectCode = isAutoFormatObjectCode;
138144
}
139145

140146
@Override
@@ -247,8 +253,12 @@ public void setTimeZone(String timeZone) {
247253
}
248254

249255
@Override
250-
public FormatConfiguration getFormatConfiguration() {
251-
return null;
256+
public IFormatConfiguration getFormatConfiguration() {
257+
return formatConfiguration;
258+
}
259+
260+
public void setFormatConfiguration(IFormatConfiguration formatConfiguration) {
261+
this.formatConfiguration = formatConfiguration;
252262
}
253263

254264
@Override
@@ -334,6 +344,8 @@ public CoreSettings copy() {
334344
settings.clusterName = clusterName;
335345
settings.parallelLoad = parallelLoad;
336346
settings.disableAutoLoad = disableAutoLoad;
347+
settings.formatConfiguration = formatConfiguration;
348+
settings.isAutoFormatObjectCode = isAutoFormatObjectCode;
337349
return settings;
338350
}
339351
}

0 commit comments

Comments
 (0)