Fix foreach in TikZ to remember more stuff between iterations#1316
Open
loopspace wants to merge 3 commits into
Open
Fix foreach in TikZ to remember more stuff between iterations#1316loopspace wants to merge 3 commits into
loopspace wants to merge 3 commits into
Conversation
Merge from upstream
This commit adds more information to what TikZ remembers between foreach iterations, and does so in a way that makes it easier to add other macros and dimensions to the list of things it remembers, both at the code level and via keys. Fixes pgf-tikz#356, pgf-tikz#1047, pgf-tikz#1303, pgf-tikz#1313 Signed-off-by: Andrew Stacey <loopspace@mathforge.org>
2 tasks
Member
|
On 2026-06-15 a more comprehensive testsuite was introduced for PGF/TikZ. This tests all new contributions against the examples extracted from the manual and checks whether anything has changed to avoid regressions. Since this pull request was opened before that, these tests were not run automatically. I have run Tip Your pull request might have failed some tests. This does not mean that your contribution will be rejected. In fact, depending on the changes you propose, it might even be expected that some tests fail, however, this needs to be evaluated carefully. All tests passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #356, #1047, #1303, #1313 by remembering more information between iterations of a foreach loop on a path, in particular the last node. Also provides a more flexible interface to remember more macros & dimensions at both the code level and the user level (the latter via pgfkeys).
See #1304 for a previous version of this pull request where something went wrong with signing the commits.
Checklist
Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead: