chore: remove outdated documentation files and add compile command tests#436
Closed
jumski wants to merge 1 commit into
Closed
chore: remove outdated documentation files and add compile command tests#436jumski wants to merge 1 commit into
jumski wants to merge 1 commit into
Conversation
|
Contributor
Author
|
View your CI Pipeline Execution ↗ for commit 3278b94
☁️ Nx Cloud last updated this comment at |
jumski
force-pushed
the
11-27-add_control_plane_test_coverage_improvements
branch
from
bc5dd5b to
3278b94
Compare
Contributor
🔍 Preview Deployment: Website✅ Deployment successful! 🔗 Preview URL: https://pr-436.pgflow.pages.dev 📝 Details:
_Last updated: _ |
This was referenced Nov 27, 2025
Contributor
Merge activity
|
graphite-app Bot
pushed a commit
that referenced
this pull request
Nov 28, 2025
…sts (#436) # Removed Auto-Compilation Documentation and Improved Compile Command Testing This PR removes two documentation files that are no longer needed: - `COMPILE_WORKER.md` - Documentation about auto-compilation workflow - `PRD_control-plane-http.md` - Product requirements document for HTTP compilation Additionally, it enhances the test coverage for the CLI's compile command with several new tests: - Added tests for migration file generation with proper timestamp formatting - Added tests for handling empty SQL array responses - Added tests for creating migrations directory when missing - Added tests for warning about existing migrations - Added error handling tests for non-existent Supabase paths - Added E2E tests for error handling with unknown flows The PR also improves the ControlPlane tests by adding: - Tests for flows with dependencies - Tests for flows with maxAttempts configuration - Tests for handling compilation errors with proper 500 responses These changes strengthen the test coverage for the compile command and ensure proper error handling throughout the compilation process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed Auto-Compilation Documentation and Improved Compile Command Testing
This PR removes two documentation files that are no longer needed:
COMPILE_WORKER.md- Documentation about auto-compilation workflowPRD_control-plane-http.md- Product requirements document for HTTP compilationAdditionally, it enhances the test coverage for the CLI's compile command with several new tests:
The PR also improves the ControlPlane tests by adding:
These changes strengthen the test coverage for the compile command and ensure proper error handling throughout the compilation process.