refactor(pg): make active major list the single source of truth

Vonng · Vonng · commit f43bd252a7ed · 2026-03-04T21:24:54.000+08:00
diff --git a/cli/build/util.go b/cli/build/util.go
@@ -4,7 +4,6 @@ import (
 	"fmt"
 	"pig/cli/ext"
 	"pig/internal/config"
-	"slices"
 	"strconv"
 	"strings"
 )
@@ -46,8 +45,8 @@ func parsePgVersions(pgVersions string) ([]int, error) {
 		}
 
 		// Validate active/supported PostgreSQL major versions
-		if !slices.Contains(ext.PostgresActiveMajorVersions, ver) {
-			return nil, fmt.Errorf("PG version %d is not supported (valid: %s)", ver, ext.PostgresActiveVersionString)
+		if !ext.IsActivePGMajor(ver) {
+			return nil, fmt.Errorf("PG version %d is not supported (valid: %s)", ver, ext.PostgresActiveVersionString())
 		}
 
 		if !seen[ver] {
diff --git a/cli/ext/alias_dynamic.go b/cli/ext/alias_dynamic.go
@@ -91,7 +91,7 @@ func parseCategoryAlias(alias string, targetPgVer int) (spec categoryAliasSpec,
 			return categoryAliasSpec{}, false
 		}
 		if targetPgVer == 0 {
-			targetPgVer = PostgresLatestMajorVersion
+			targetPgVer = PostgresLatestMajorVersion()
 		}
 		return categoryAliasSpec{
 			category: category,
@@ -113,7 +113,7 @@ func parseCategoryAlias(alias string, targetPgVer int) (spec categoryAliasSpec,
 	if err != nil {
 		return categoryAliasSpec{}, false
 	}
-	if !slices.Contains(PostgresActiveMajorVersions, ver) {
+	if !IsActivePGMajor(ver) {
 		return categoryAliasSpec{}, false
 	}
 
@@ -172,7 +172,7 @@ func buildCategoryPackageList(spec categoryAliasSpec, matrixOS, matrixArch strin
 	seen := make(map[string]struct{})
 	selectPG := spec.targetPG
 	if spec.isPgsql {
-		selectPG = PostgresLatestMajorVersion
+		selectPG = PostgresLatestMajorVersion()
 	}
 
 	for _, ext := range Catalog.Extensions {
@@ -272,11 +272,11 @@ func applyCategoryPackageSpecialCase(ext *Extension, pkgName string, pgVer int)
 }
 
 func rewriteLatestCategoryPkgToTarget(pkg string, targetPG int) string {
-	if targetPG == PostgresLatestMajorVersion {
+	if targetPG == PostgresLatestMajorVersion() {
 		return pkg
 	}
 
-	latest := strconv.Itoa(PostgresLatestMajorVersion)
+	latest := strconv.Itoa(PostgresLatestMajorVersion())
 	target := strconv.Itoa(targetPG)
 
 	switch config.OSType {
diff --git a/cli/ext/extension.go b/cli/ext/extension.go
@@ -88,11 +88,6 @@ func CompactVersion(pgVers []string) string {
 	return fmt.Sprintf("%d-%d", filteredVers[0], filteredVers[len(filteredVers)-1])
 }
 
-// isActivePGMajor checks whether the PostgreSQL major version is in active support window.
-func isActivePGMajor(ver int) bool {
-	return slices.Contains(PostgresActiveMajorVersions, ver)
-}
-
 // filterActivePGVersionStrings keeps supported PG majors in input order, deduplicated.
 func filterActivePGVersionStrings(pgVers []string) []string {
 	filtered := make([]string, 0, len(pgVers))
@@ -103,7 +98,7 @@ func filterActivePGVersionStrings(pgVers []string) []string {
 			continue
 		}
 		verInt, err := strconv.Atoi(ver)
-		if err != nil || !isActivePGMajor(verInt) || seen[verInt] {
+		if err != nil || !IsActivePGMajor(verInt) || seen[verInt] {
 			continue
 		}
 		filtered = append(filtered, strconv.Itoa(verInt))
diff --git a/cli/ext/import.go b/cli/ext/import.go
@@ -22,8 +22,8 @@ func ImportExtensionsResult(pgVer int, names []string, importPath string) *outpu
 	}
 
 	if pgVer == 0 {
-		logrus.Debugf("no PostgreSQL version specified, set target version to the latest major version: %d", PostgresLatestMajorVersion)
-		pgVer = PostgresLatestMajorVersion
+		logrus.Debugf("no PostgreSQL version specified, set target version to the latest major version: %d", PostgresLatestMajorVersion())
+		pgVer = PostgresLatestMajorVersion()
 	}
 
 	if importPath == "" {
diff --git a/cli/ext/matrix.go b/cli/ext/matrix.go
@@ -230,7 +230,7 @@ func (m PkgMatrix) PGList() []int {
 	}
 	seen := make(map[int]bool)
 	for _, e := range m {
-		if e != nil && isActivePGMajor(e.PG) {
+		if e != nil && IsActivePGMajor(e.PG) {
 			seen[e.PG] = true
 		}
 	}
diff --git a/cli/ext/operation.go b/cli/ext/operation.go
@@ -43,8 +43,8 @@ func prepareExtensionPkgOp(opts preparePkgOpOptions) (*preparedPkgOp, *output.Re
 
 	pgVer := opts.PgVersion
 	if pgVer == 0 {
-		logrus.Debugf("using latest postgres version: %d by default", PostgresLatestMajorVersion)
-		pgVer = PostgresLatestMajorVersion
+		logrus.Debugf("using latest postgres version: %d by default", PostgresLatestMajorVersion())
+		pgVer = PostgresLatestMajorVersion()
 	}
 
 	// Check OS support.
diff --git a/cli/ext/pgsql.go b/cli/ext/pgsql.go
@@ -7,6 +7,8 @@ import (
 	"path/filepath"
 	"pig/internal/config"
 	"pig/internal/utils"
+	"slices"
+	"sort"
 	"strconv"
 	"strings"
 	"text/tabwriter"
@@ -39,19 +41,41 @@ var (
 )
 
 var (
-	PostgresActiveMajorVersions    = []int{18, 17, 16, 15, 14}
-	PostgresActiveMajorVersionsAsc = []int{14, 15, 16, 17, 18}
-	PostgresLatestMajorVersion     = 18
-	PostgresActiveVersionString = formatActiveVersions()
+	// PostgresActiveMajorVersions is the single source of truth for active PG majors.
+	PostgresActiveMajorVersions = []int{18, 17, 16, 15, 14}
 	PostgresElSearchPath        = []string{"/usr/pgsql-%s/bin/pg_config"}
 	PostgresDEBSearchPath       = []string{"/usr/lib/postgresql/%s/bin/pg_config"}
 	PostgresMACSearchPath       = []string{"/opt/homebrew/opt/postgresql@%s/bin/pg_config"}
 )
 
-// formatActiveVersions returns a comma-separated string of active PG versions (ascending).
-func formatActiveVersions() string {
-	parts := make([]string, len(PostgresActiveMajorVersionsAsc))
-	for i, v := range PostgresActiveMajorVersionsAsc {
+// IsActivePGMajor checks whether the PostgreSQL major version is in active support window.
+func IsActivePGMajor(ver int) bool {
+	return slices.Contains(PostgresActiveMajorVersions, ver)
+}
+
+// PostgresLatestMajorVersion returns the maximum active PG major version.
+func PostgresLatestMajorVersion() int {
+	latest := 0
+	for _, v := range PostgresActiveMajorVersions {
+		if v > latest {
+			latest = v
+		}
+	}
+	return latest
+}
+
+// PostgresActiveMajorVersionsAsc returns active PG versions sorted ascending.
+func PostgresActiveMajorVersionsAsc() []int {
+	versions := append([]int(nil), PostgresActiveMajorVersions...)
+	sort.Ints(versions)
+	return versions
+}
+
+// PostgresActiveVersionString returns a comma-separated string of active PG versions (ascending).
+func PostgresActiveVersionString() string {
+	asc := PostgresActiveMajorVersionsAsc()
+	parts := make([]string, len(asc))
+	for i, v := range asc {
 		parts[i] = strconv.Itoa(v)
 	}
 	return strings.Join(parts, ",")
diff --git a/cli/ext/plan.go b/cli/ext/plan.go
@@ -106,7 +106,7 @@ func BuildAddPlan(pgVer int, names []string, yes bool) *output.Plan {
 	}
 
 	if pgVer == 0 {
-		pgVer = PostgresLatestMajorVersion
+		pgVer = PostgresLatestMajorVersion()
 	}
 
 	resolved, notFound := resolvePlanExtensions(pgVer, names, true)
@@ -299,7 +299,7 @@ func BuildRmPlan(pgVer int, names []string, yes bool) *output.Plan {
 	}
 
 	if pgVer == 0 {
-		pgVer = PostgresLatestMajorVersion
+		pgVer = PostgresLatestMajorVersion()
 	}
 
 	resolved, notFound := resolvePlanExtensions(pgVer, names, false)
diff --git a/cli/ext/result_test.go b/cli/ext/result_test.go
@@ -1625,13 +1625,13 @@ func TestAddExtensionsDefaultPgVersion(t *testing.T) {
 		t.Fatal("expected non-nil result")
 	}
 
-	// Should use PostgresLatestMajorVersion by default
+	// Should use PostgresLatestMajorVersion() by default
 	data, ok := result.Data.(*ExtensionAddData)
 	if !ok {
 		t.Fatal("expected data to be *ExtensionAddData")
 	}
-	if data.PgVersion != PostgresLatestMajorVersion {
-		t.Errorf("expected PgVersion=%d, got %d", PostgresLatestMajorVersion, data.PgVersion)
+	if data.PgVersion != PostgresLatestMajorVersion() {
+		t.Errorf("expected PgVersion=%d, got %d", PostgresLatestMajorVersion(), data.PgVersion)
 	}
 }
 
@@ -2270,13 +2270,13 @@ func TestRmExtensionsDefaultPgVersion(t *testing.T) {
 		t.Fatal("expected non-nil result")
 	}
 
-	// Should use PostgresLatestMajorVersion by default
+	// Should use PostgresLatestMajorVersion() by default
 	data, ok := result.Data.(*ExtensionRmData)
 	if !ok {
 		t.Fatal("expected data to be *ExtensionRmData")
 	}
-	if data.PgVersion != PostgresLatestMajorVersion {
-		t.Errorf("expected PgVersion=%d, got %d", PostgresLatestMajorVersion, data.PgVersion)
+	if data.PgVersion != PostgresLatestMajorVersion() {
+		t.Errorf("expected PgVersion=%d, got %d", PostgresLatestMajorVersion(), data.PgVersion)
 	}
 }
 
@@ -2466,13 +2466,13 @@ func TestUpgradeExtensionsDefaultPgVersion(t *testing.T) {
 		t.Fatal("expected non-nil result")
 	}
 
-	// Should use PostgresLatestMajorVersion by default
+	// Should use PostgresLatestMajorVersion() by default
 	data, ok := result.Data.(*ExtensionUpdateData)
 	if !ok {
 		t.Fatal("expected data to be *ExtensionUpdateData")
 	}
-	if data.PgVersion != PostgresLatestMajorVersion {
-		t.Errorf("expected PgVersion=%d, got %d", PostgresLatestMajorVersion, data.PgVersion)
+	if data.PgVersion != PostgresLatestMajorVersion() {
+		t.Errorf("expected PgVersion=%d, got %d", PostgresLatestMajorVersion(), data.PgVersion)
 	}
 }
 
diff --git a/cli/ext/update.go b/cli/ext/update.go
@@ -16,7 +16,7 @@ func UpgradeExtensions(pgVer int, names []string, yes bool) *output.Result {
 	// Safety: never auto-upgrade everything. Without explicit targets, do nothing.
 	if len(names) == 0 {
 		if pgVer == 0 {
-			pgVer = PostgresLatestMajorVersion
+			pgVer = PostgresLatestMajorVersion()
 		}
 		data := &ExtensionUpdateData{
 			PgVersion:   pgVer,
diff --git a/cli/install/install.go b/cli/install/install.go
@@ -17,8 +17,8 @@ func InstallPackages(pgVer int, names []string, yes bool, noTranslation bool) er
 		return fmt.Errorf("no package names provided")
 	}
 	if pgVer == 0 {
-		logrus.Debugf("no PostgreSQL version specified, set target version to the latest major version: %d", ext.PostgresLatestMajorVersion)
-		pgVer = ext.PostgresLatestMajorVersion
+		logrus.Debugf("no PostgreSQL version specified, set target version to the latest major version: %d", ext.PostgresLatestMajorVersion())
+		pgVer = ext.PostgresLatestMajorVersion()
 	}
 
 	var installCmds []string
diff --git a/cli/install/plan.go b/cli/install/plan.go
@@ -23,7 +23,7 @@ func BuildInstallPlan(pgVer int, names []string, yes bool, noTranslation bool) *
 	}
 
 	if pgVer == 0 {
-		pgVer = ext.PostgresLatestMajorVersion
+		pgVer = ext.PostgresLatestMajorVersion()
 	}
 
 	pkgMgr, err := detectInstallPackageManager()
diff --git a/cli/sty/configure.go b/cli/sty/configure.go
@@ -329,8 +329,8 @@ func validatePGVersion(ver string) (int, error) {
 	if err != nil {
 		return 0, fmt.Errorf("invalid pg major version: %s", ver)
 	}
-	if !slices.Contains(ext.PostgresActiveMajorVersions, v) {
-		return 0, fmt.Errorf("invalid pg major version: %s (valid: %s)", ver, ext.PostgresActiveVersionString)
+	if !ext.IsActivePGMajor(v) {
+		return 0, fmt.Errorf("invalid pg major version: %s (valid: %s)", ver, ext.PostgresActiveVersionString())
 	}
 	return v, nil
 }
diff --git a/cmd/install.go b/cmd/install.go
@@ -98,7 +98,7 @@ func installProbeVersion() (int, error) {
 	return probePostgresMajorVersion(pgMajorProbeOptions{
 		Version:        installPgVer,
 		PGConfig:       installPgConfig,
-		DefaultVersion: ext.PostgresLatestMajorVersion,
+		DefaultVersion: ext.PostgresLatestMajorVersion(),
 		BothSetError: func() error {
 			return fmt.Errorf("both pg version and pg_config path are specified, please specify only one")
 		},

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,6 @@ import (`
`4`	`4`	`"fmt"`
`5`	`5`	`"pig/cli/ext"`
`6`	`6`	`"pig/internal/config"`
`7`		`- "slices"`
`8`	`7`	`"strconv"`
`9`	`8`	`"strings"`
`10`	`9`	`)`
`@@ -46,8 +45,8 @@ func parsePgVersions(pgVersions string) ([]int, error) {`
`46`	`45`	`}`
`47`	`46`
`48`	`47`	`// Validate active/supported PostgreSQL major versions`
`49`		`- if !slices.Contains(ext.PostgresActiveMajorVersions, ver) {`
`50`		`- return nil, fmt.Errorf("PG version %d is not supported (valid: %s)", ver, ext.PostgresActiveVersionString)`
	`48`	`+ if !ext.IsActivePGMajor(ver) {`
	`49`	`+ return nil, fmt.Errorf("PG version %d is not supported (valid: %s)", ver, ext.PostgresActiveVersionString())`
`51`	`50`	`}`
`52`	`51`
`53`	`52`	`if !seen[ver] {`
Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ func parseCategoryAlias(alias string, targetPgVer int) (spec categoryAliasSpec,`
`91`	`91`	`return categoryAliasSpec{}, false`
`92`	`92`	`}`
`93`	`93`	`if targetPgVer == 0 {`
`94`		`- targetPgVer = PostgresLatestMajorVersion`
	`94`	`+ targetPgVer = PostgresLatestMajorVersion()`
`95`	`95`	`}`
`96`	`96`	`return categoryAliasSpec{`
`97`	`97`	`category: category,`
`@@ -113,7 +113,7 @@ func parseCategoryAlias(alias string, targetPgVer int) (spec categoryAliasSpec,`
`113`	`113`	`if err != nil {`
`114`	`114`	`return categoryAliasSpec{}, false`
`115`	`115`	`}`
`116`		`- if !slices.Contains(PostgresActiveMajorVersions, ver) {`
	`116`	`+ if !IsActivePGMajor(ver) {`
`117`	`117`	`return categoryAliasSpec{}, false`
`118`	`118`	`}`
`119`	`119`
`@@ -172,7 +172,7 @@ func buildCategoryPackageList(spec categoryAliasSpec, matrixOS, matrixArch strin`
`172`	`172`	`seen := make(map[string]struct{})`
`173`	`173`	`selectPG := spec.targetPG`
`174`	`174`	`if spec.isPgsql {`
`175`		`- selectPG = PostgresLatestMajorVersion`
	`175`	`+ selectPG = PostgresLatestMajorVersion()`
`176`	`176`	`}`
`177`	`177`
`178`	`178`	`for _, ext := range Catalog.Extensions {`
`@@ -272,11 +272,11 @@ func applyCategoryPackageSpecialCase(ext *Extension, pkgName string, pgVer int)`
`272`	`272`	`}`
`273`	`273`
`274`	`274`	`func rewriteLatestCategoryPkgToTarget(pkg string, targetPG int) string {`
`275`		`- if targetPG == PostgresLatestMajorVersion {`
	`275`	`+ if targetPG == PostgresLatestMajorVersion() {`
`276`	`276`	`return pkg`
`277`	`277`	`}`
`278`	`278`
`279`		`- latest := strconv.Itoa(PostgresLatestMajorVersion)`
	`279`	`+ latest := strconv.Itoa(PostgresLatestMajorVersion())`
`280`	`280`	`target := strconv.Itoa(targetPG)`
`281`	`281`
`282`	`282`	`switch config.OSType {`
Original file line number	Diff line number	Diff line change
`@@ -88,11 +88,6 @@ func CompactVersion(pgVers []string) string {`
`88`	`88`	`return fmt.Sprintf("%d-%d", filteredVers[0], filteredVers[len(filteredVers)-1])`
`89`	`89`	`}`
`90`	`90`
`91`		`-// isActivePGMajor checks whether the PostgreSQL major version is in active support window.`
`92`		`-func isActivePGMajor(ver int) bool {`
`93`		`- return slices.Contains(PostgresActiveMajorVersions, ver)`
`94`		`-}`
`95`		`-`
`96`	`91`	`// filterActivePGVersionStrings keeps supported PG majors in input order, deduplicated.`
`97`	`92`	`func filterActivePGVersionStrings(pgVers []string) []string {`
`98`	`93`	`filtered := make([]string, 0, len(pgVers))`
`@@ -103,7 +98,7 @@ func filterActivePGVersionStrings(pgVers []string) []string {`
`103`	`98`	`continue`
`104`	`99`	`}`
`105`	`100`	`verInt, err := strconv.Atoi(ver)`
`106`		`- if err != nil \|\| !isActivePGMajor(verInt) \|\| seen[verInt] {`
	`101`	`+ if err != nil \|\| !IsActivePGMajor(verInt) \|\| seen[verInt] {`
`107`	`102`	`continue`
`108`	`103`	`}`
`109`	`104`	`filtered = append(filtered, strconv.Itoa(verInt))`
Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,8 @@ func ImportExtensionsResult(pgVer int, names []string, importPath string) *outpu`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`if pgVer == 0 {`
`25`		`- logrus.Debugf("no PostgreSQL version specified, set target version to the latest major version: %d", PostgresLatestMajorVersion)`
`26`		`- pgVer = PostgresLatestMajorVersion`
	`25`	`+ logrus.Debugf("no PostgreSQL version specified, set target version to the latest major version: %d", PostgresLatestMajorVersion())`
	`26`	`+ pgVer = PostgresLatestMajorVersion()`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`if importPath == "" {`
Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,7 @@ func (m PkgMatrix) PGList() []int {`
`230`	`230`	`}`
`231`	`231`	`seen := make(map[int]bool)`
`232`	`232`	`for _, e := range m {`
`233`		`- if e != nil && isActivePGMajor(e.PG) {`
	`233`	`+ if e != nil && IsActivePGMajor(e.PG) {`
`234`	`234`	`seen[e.PG] = true`
`235`	`235`	`}`
`236`	`236`	`}`
Original file line number	Diff line number	Diff line change
`@@ -43,8 +43,8 @@ func prepareExtensionPkgOp(opts preparePkgOpOptions) (preparedPkgOp, output.Re`
`43`	`43`
`44`	`44`	`pgVer := opts.PgVersion`
`45`	`45`	`if pgVer == 0 {`
`46`		`- logrus.Debugf("using latest postgres version: %d by default", PostgresLatestMajorVersion)`
`47`		`- pgVer = PostgresLatestMajorVersion`
	`46`	`+ logrus.Debugf("using latest postgres version: %d by default", PostgresLatestMajorVersion())`
	`47`	`+ pgVer = PostgresLatestMajorVersion()`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`// Check OS support.`
Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ func BuildAddPlan(pgVer int, names []string, yes bool) *output.Plan {`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`if pgVer == 0 {`
`109`		`- pgVer = PostgresLatestMajorVersion`
	`109`	`+ pgVer = PostgresLatestMajorVersion()`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`resolved, notFound := resolvePlanExtensions(pgVer, names, true)`
`@@ -299,7 +299,7 @@ func BuildRmPlan(pgVer int, names []string, yes bool) *output.Plan {`
`299`	`299`	`}`
`300`	`300`
`301`	`301`	`if pgVer == 0 {`
`302`		`- pgVer = PostgresLatestMajorVersion`
	`302`	`+ pgVer = PostgresLatestMajorVersion()`
`303`	`303`	`}`
`304`	`304`
`305`	`305`	`resolved, notFound := resolvePlanExtensions(pgVer, names, false)`
Original file line number	Diff line number	Diff line change
`@@ -1625,13 +1625,13 @@ func TestAddExtensionsDefaultPgVersion(t *testing.T) {`
`1625`	`1625`	`t.Fatal("expected non-nil result")`
`1626`	`1626`	`}`
`1627`	`1627`
`1628`		`- // Should use PostgresLatestMajorVersion by default`
	`1628`	`+ // Should use PostgresLatestMajorVersion() by default`
`1629`	`1629`	`data, ok := result.Data.(*ExtensionAddData)`
`1630`	`1630`	`if !ok {`
`1631`	`1631`	`t.Fatal("expected data to be *ExtensionAddData")`
`1632`	`1632`	`}`
`1633`		`- if data.PgVersion != PostgresLatestMajorVersion {`
`1634`		`- t.Errorf("expected PgVersion=%d, got %d", PostgresLatestMajorVersion, data.PgVersion)`
	`1633`	`+ if data.PgVersion != PostgresLatestMajorVersion() {`
	`1634`	`+ t.Errorf("expected PgVersion=%d, got %d", PostgresLatestMajorVersion(), data.PgVersion)`
`1635`	`1635`	`}`
`1636`	`1636`	`}`
`1637`	`1637`
`@@ -2270,13 +2270,13 @@ func TestRmExtensionsDefaultPgVersion(t *testing.T) {`
`2270`	`2270`	`t.Fatal("expected non-nil result")`
`2271`	`2271`	`}`
`2272`	`2272`
`2273`		`- // Should use PostgresLatestMajorVersion by default`
	`2273`	`+ // Should use PostgresLatestMajorVersion() by default`
`2274`	`2274`	`data, ok := result.Data.(*ExtensionRmData)`
`2275`	`2275`	`if !ok {`
`2276`	`2276`	`t.Fatal("expected data to be *ExtensionRmData")`
`2277`	`2277`	`}`
`2278`		`- if data.PgVersion != PostgresLatestMajorVersion {`
`2279`		`- t.Errorf("expected PgVersion=%d, got %d", PostgresLatestMajorVersion, data.PgVersion)`
	`2278`	`+ if data.PgVersion != PostgresLatestMajorVersion() {`
	`2279`	`+ t.Errorf("expected PgVersion=%d, got %d", PostgresLatestMajorVersion(), data.PgVersion)`
`2280`	`2280`	`}`
`2281`	`2281`	`}`
`2282`	`2282`
`@@ -2466,13 +2466,13 @@ func TestUpgradeExtensionsDefaultPgVersion(t *testing.T) {`
`2466`	`2466`	`t.Fatal("expected non-nil result")`
`2467`	`2467`	`}`
`2468`	`2468`
`2469`		`- // Should use PostgresLatestMajorVersion by default`
	`2469`	`+ // Should use PostgresLatestMajorVersion() by default`
`2470`	`2470`	`data, ok := result.Data.(*ExtensionUpdateData)`
`2471`	`2471`	`if !ok {`
`2472`	`2472`	`t.Fatal("expected data to be *ExtensionUpdateData")`
`2473`	`2473`	`}`
`2474`		`- if data.PgVersion != PostgresLatestMajorVersion {`
`2475`		`- t.Errorf("expected PgVersion=%d, got %d", PostgresLatestMajorVersion, data.PgVersion)`
	`2474`	`+ if data.PgVersion != PostgresLatestMajorVersion() {`
	`2475`	`+ t.Errorf("expected PgVersion=%d, got %d", PostgresLatestMajorVersion(), data.PgVersion)`
`2476`	`2476`	`}`
`2477`	`2477`	`}`
`2478`	`2478`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ func UpgradeExtensions(pgVer int, names []string, yes bool) *output.Result {`
`16`	`16`	`// Safety: never auto-upgrade everything. Without explicit targets, do nothing.`
`17`	`17`	`if len(names) == 0 {`
`18`	`18`	`if pgVer == 0 {`
`19`		`- pgVer = PostgresLatestMajorVersion`
	`19`	`+ pgVer = PostgresLatestMajorVersion()`
`20`	`20`	`}`
`21`	`21`	`data := &ExtensionUpdateData{`
`22`	`22`	`PgVersion: pgVer,`