Reduce minimum nfcapd time to 1 second#664
Closed
MuriloChianfa wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @phaag,
I'm trying to reduce to 1 second the nfcapd rotation time and so far it looks good, there is any reason that I should be aware on why you restricted into 2 seconds? or else we could reduce it, maybe into sub-seconds later. 👀👀
Tests Made
NetFlow v9 exporter exporting to port 2055, then an samplicator listening and replaying to two different nfcapd:
Now, one baseline nfcapd listening using -t 2:
And the new version using -t 1:
After some time, they both captured the same traffic:
Note
They both had 10307 flows
This test was made only using NetFlow v9. Further tests may be needed with sflow on sfcapd and raw packets in nfpcapd. Let me know you thoughts about. Thanks.