Skip to content

added multistage docker builds with docker instructions in readme#675

Merged
phaag merged 1 commit into
phaag:masterfrom
heywoodlh:docker-multistage-builds
May 9, 2026
Merged

added multistage docker builds with docker instructions in readme#675
phaag merged 1 commit into
phaag:masterfrom
heywoodlh:docker-multistage-builds

Conversation

@heywoodlh
Copy link
Copy Markdown
Contributor

@heywoodlh heywoodlh commented May 7, 2026

Round two of #618 😄

Changes:

  • Multistage builds should reduce the size of the image (and decrease vulnerabilities)
  • Removed hardcoding the version of nfdump, builds nfdump from source
  • Separate targets for nfcapd and nfdump (i.e. one target for being the server and one for the client)
  • Copy the repo source into the image instead of downloading and extracting an archive of nfdump
  • Added documentation for building the image (Alpine being the assumed base build)
  • Running as non-root user by default

Related #674

@heywoodlh
Copy link
Copy Markdown
Contributor Author

If this gets merged, the following future additions would be nice:

  • Images pushed to ghcr.io or Docker Hub
  • GitHub Actions to regularly build, test and push images

@phaag
Copy link
Copy Markdown
Owner

phaag commented May 9, 2026

The docker file is a 3rd party file. I'd happily add your PR but I do not check or verify the code.

@phaag phaag merged commit 7b29b34 into phaag:master May 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants