Prepare 3.2.0 release

Author: jturbide

CHANGELOG.md

@@ -15,7 +15,7 @@ history, the old changelog, and committed file changes. Older Zemit-era entries
 are summarized where the commit history is too granular to be useful as
 release notes.
 
-## 3.1.5 - Unreleased
+## 3.2.0 - 2026-06-16
 
 ### Added
 

src/Mvc/Model/Behavior/Blameable.php

@@ -193,10 +193,6 @@ public function createAudit(string $type, Model $model): bool
 
         $audit = $this->requireAuditRecord($audit);
 
-        if (!$this->hasAuditModelStorage($audit)) {
-            return true;
-        }
-
         // Populate core audit metadata
         $audit->setModel($model::class);
         $audit->setTable($model->getSource());
@@ -224,52 +220,49 @@ public function createAudit(string $type, Model $model): bool
         if ($this->isAuditDetailEnabled()) {
             $details = [];
             $detailClass = $this->auditDetailClass;
-            $detailPrototype = $this->requireAuditDetailRecord(new $detailClass());
-
-            if ($this->hasAuditModelStorage($detailPrototype)) {
-                foreach ($columns as $column) {
-                    $map = $columnMap[$column] ?? $column;
-                    $type = $columnTypes[$column] ?? null;
-
-                    $before = $this->normalizeValue($snapshot[$map] ?? null, $type);
-                    $after  = $this->normalizeValue($model->readAttribute($map), $type);
-
-                    // Skip unchanged fields on update
-                    if (
-                        $event === 'update' &&
-                        $changed !== null &&
-                        $snapshot !== null &&
-                        ($before === $after || !in_array($map, $changed, true))
-                    ) {
-                        continue;
-                    }
-
-                    $detail = $this->requireAuditDetailRecord(new $detailClass());
-
-                    $detail->setColumn($column);
-                    $detail->setBefore($before);
-                    $detail->setAfter($after);
-
-                    // Legacy compatibility fields
-                    $detail->assign([
-                        'model' => $audit->getModel(),
-                        'table' => $audit->getTable(),
-                        'primary' => $audit->getPrimary(),
-                        'event' => $event,
-                        'map' => $map,
-                    ]);
-
-                    $details[] = $detail;
-                }
 
-                if ($details !== []) {
-                    $audit->assign(['AuditDetailList' => $details]);
+            foreach ($columns as $column) {
+                $map = $columnMap[$column] ?? $column;
+                $type = $columnTypes[$column] ?? null;
+
+                $before = $this->normalizeValue($snapshot[$map] ?? null, $type);
+                $after  = $this->normalizeValue($model->readAttribute($map), $type);
+
+                // Skip unchanged fields on update
+                if (
+                    $event === 'update' &&
+                    $changed !== null &&
+                    $snapshot !== null &&
+                    ($before === $after || !in_array($map, $changed, true))
+                ) {
+                    continue;
                 }
+
+                $detail = $this->requireAuditDetailRecord(new $detailClass());
+
+                $detail->setColumn($column);
+                $detail->setBefore($before);
+                $detail->setAfter($after);
+
+                // Legacy compatibility fields
+                $detail->assign([
+                    'model' => $audit->getModel(),
+                    'table' => $audit->getTable(),
+                    'primary' => $audit->getPrimary(),
+                    'event' => $event,
+                    'map' => $map,
+                ]);
+
+                $details[] = $detail;
+            }
+
+            if ($details !== []) {
+                $audit->assign(['AuditDetailList' => $details]);
             }
         }
 
         // Persist audit (and details via relationship)
-        $saved = $audit->save();
+        $saved = $this->saveAuditRecord($audit);
 
         // Propagate audit validation errors back to the source model
         foreach ($audit->getMessages() as $message) {
@@ -341,24 +334,20 @@ protected function requireAuditRecord(mixed $audit): AuditInterface&Model
     }
 
     /**
-     * Return true when the configured audit model has backing metadata.
+     * Save the audit record unless audit storage is explicitly absent.
      *
      * Missing audit tables are optional in some applications, so a concrete
-     * `TableNotInDatabase` skips audit creation. An unavailable local database
-     * is not the same signal; let the normal save path or test double decide
-     * instead of silently disabling audit.
+     * `TableNotInDatabase` skips audit creation. The guard is intentionally at
+     * the save boundary so fake/custom audit models that override persistence
+     * still run normally.
      */
-    protected function hasAuditModelStorage(Model $model): bool
+    protected function saveAuditRecord(AuditInterface&Model $audit): bool
     {
         try {
-            $model->getModelsMetaData()->getAttributes($model);
+            return $audit->save();
         } catch (TableNotInDatabase) {
-            return false;
-        } catch (\PDOException) {
             return true;
         }
-
-        return true;
     }
 
     /**

tests/Unit/Mvc/Model/BehaviorAndTraitsTest.php

@@ -610,6 +610,12 @@ public function testBlameableNotifyAndCreateAudit(): void
         $this->assertSame('Audit.event', $model->messages[0]->getField());
 
         FakeAudit::$messages = [];
+        FakeAudit::reset();
+        FakeAudit::$throwMissingTableOnSave = true;
+        $this->assertTrue($behavior->createAudit('afterUpdate', $model));
+        $this->assertNull(FakeAudit::$last);
+
+        FakeAudit::reset();
         $noSnapshot = new ModelBehaviorDouble();
         $this->assertFalse($behavior->notify('beforeUpdate', $noSnapshot));
 

tests/Unit/Mvc/Model/Fixtures/FakeAudit.php

@@ -13,13 +13,15 @@
 
 namespace PhalconKit\Tests\Unit\Mvc\Model\Fixtures;
 
+use Phalcon\Mvc\Model\MetaData\Exceptions\TableNotInDatabase;
 use Phalcon\Mvc\ModelInterface;
 use PhalconKit\Models\Audit;
 
 class FakeAudit extends Audit
 {
     public static ?self $last = null;
     public static bool $saveResult = true;
+    public static bool $throwMissingTableOnSave = false;
     public static array $messages = [];
     public static mixed $nextId = 77;
 
@@ -45,6 +47,10 @@ public function assign(array $data, $whiteList = null, $dataColumnMap = null): M
     #[\Override]
     public function save(): bool
     {
+        if (self::$throwMissingTableOnSave) {
+            throw new TableNotInDatabase($this->getSource(), self::class);
+        }
+
         self::$last = $this;
         $this->id = self::$nextId;
         return self::$saveResult;
@@ -60,6 +66,7 @@ public static function reset(): void
     {
         self::$last = null;
         self::$saveResult = true;
+        self::$throwMissingTableOnSave = false;
         self::$messages = [];
         self::$nextId = 77;
     }