Conversation
sergeyklay
approved these changes
Oct 26, 2019
Jeckerson
approved these changes
Oct 27, 2019
Contributor
|
I want to hold on this for a moment. I need to ask Crowdin a couple of questions so that we can remove the manual aspect of this change. With this change all languages are I need to see if there is something in their API that will allow us to automate this. |
Arhell
approved these changes
Nov 9, 2019
Contributor
Author
|
@niden Did we we had any feedback from Crowdin? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was thinking to solve the seo issue like this.
In supported we can set the preferred canonical language this will be reflected in the meta tags.