Skip to content

Commit fdb2ccc

Browse files
committed
CI: packaging improvements
1 parent 2fe03d7 commit fdb2ccc

3 files changed

Lines changed: 21 additions & 13 deletions

File tree

.github/workflows/main.yml

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,18 @@ jobs:
5454
5555
- name: 'Package'
5656
if: success() && ((github.ref_type == 'tag') || (github.event_name == 'workflow_dispatch')) && github.event_name != 'pull_request'
57-
run: iscc.exe /O"${{github.workspace}}/installer" "${{github.workspace}}/installer/installer.iss"
57+
run: |
58+
iscc.exe /O"${{github.workspace}}/installer" "${{github.workspace}}/installer/installer.iss"
59+
7z.exe a -r -y -tzip -mx9 "${{github.workspace}}/installer/Waveform_${{github.ref_name}}_Windows_x86_64.zip" "${{github.workspace}}/installer/bin/*"
5860
5961
- name: 'Upload'
6062
if: success() && ((github.ref_type == 'tag') || (github.event_name == 'workflow_dispatch')) && github.event_name != 'pull_request'
6163
uses: actions/upload-artifact@v7
6264
with:
6365
name: Waveform_${{github.ref_name}}_Windows_x64
64-
path: ${{github.workspace}}/installer/Waveform_v*_setup.exe
66+
path: |
67+
${{github.workspace}}/installer/Waveform_v*_setup.exe
68+
"${{github.workspace}}/installer/Waveform_${{github.ref_name}}_Windows_x86_64.zip"
6569
6670
macosarm64:
6771
name: 'MacOS Arm64'
@@ -89,7 +93,7 @@ jobs:
8993
cmake --install ${{github.workspace}}/deps/obs-studio/build --component Development --config Release
9094
9195
- name: 'Cmake'
92-
run: cmake -S ${{github.workspace}} -B ${{github.workspace}}/build -DCI_BUILD=ON -DCMAKE_OSX_DEPLOYMENT_TARGET=12.0 -DCMAKE_OSX_ARCHITECTURES="arm64" -DMAKE_BUNDLE=ON -DENABLE_X86_SIMD=OFF -DBUILTIN_FFTW=ON -DCMAKE_PREFIX_PATH="${{github.workspace}}/deps/obs_install;${{github.workspace}}/deps/obs-studio/build/libobs" -DCMAKE_INSTALL_PREFIX="${{github.workspace}}/bin"
96+
run: cmake -S ${{github.workspace}} -B ${{github.workspace}}/build -G Xcode -DCI_BUILD=ON -DCMAKE_OSX_DEPLOYMENT_TARGET=12.0 -DCMAKE_OSX_ARCHITECTURES="arm64" -DMAKE_BUNDLE=ON -DENABLE_X86_SIMD=OFF -DBUILTIN_FFTW=ON -DCMAKE_PREFIX_PATH="${{github.workspace}}/deps/obs_install;${{github.workspace}}/deps/obs-studio/build/libobs" -DCMAKE_INSTALL_PREFIX="${{github.workspace}}/bin"
9397

9498
- name: 'Build'
9599
run: |
@@ -107,9 +111,9 @@ jobs:
107111
name: Waveform_${{github.ref_name}}_MacOS_arm64
108112
path: ${{github.workspace}}/build/*.pkg
109113

110-
macos64:
114+
macosx64:
111115
name: 'MacOS x64'
112-
runs-on: macos-26
116+
runs-on: macos-26-intel
113117
steps:
114118
- name: 'Checkout'
115119
uses: actions/checkout@v7
@@ -133,7 +137,7 @@ jobs:
133137
cmake --install ${{github.workspace}}/deps/obs-studio/build --component Development --config Release
134138
135139
- name: 'Cmake'
136-
run: cmake -S ${{github.workspace}} -B ${{github.workspace}}/build -DCI_BUILD=ON -DCMAKE_OSX_DEPLOYMENT_TARGET=12.0 -DCMAKE_OSX_ARCHITECTURES="x86_64" -DMAKE_BUNDLE=ON -DBUILTIN_FFTW=ON -DCMAKE_PREFIX_PATH="${{github.workspace}}/deps/obs_install;${{github.workspace}}/deps/obs-studio/build/libobs" -DCMAKE_INSTALL_PREFIX="${{github.workspace}}/bin"
140+
run: cmake -S ${{github.workspace}} -B ${{github.workspace}}/build -G Xcode -DCI_BUILD=ON -DCMAKE_OSX_DEPLOYMENT_TARGET=12.0 -DCMAKE_OSX_ARCHITECTURES="x86_64" -DMAKE_BUNDLE=ON -DBUILTIN_FFTW=ON -DCMAKE_PREFIX_PATH="${{github.workspace}}/deps/obs_install;${{github.workspace}}/deps/obs-studio/build/libobs" -DCMAKE_INSTALL_PREFIX="${{github.workspace}}/bin"
137141

138142
- name: 'Build'
139143
run: |
@@ -151,7 +155,7 @@ jobs:
151155
name: Waveform_${{github.ref_name}}_MacOS_x86_64
152156
path: ${{github.workspace}}/build/*.pkg
153157

154-
ubuntu64:
158+
ubuntux64:
155159
name: 'Ubuntu x64'
156160
runs-on: ubuntu-latest
157161
steps:
@@ -186,7 +190,7 @@ jobs:
186190

187191
publish_release:
188192
if: ((github.ref_type == 'tag') || (inputs.publish == true)) && github.event_name != 'pull_request'
189-
needs: [macosarm64, macos64, ubuntu64, windowsx64]
193+
needs: [macosarm64, macosx64, ubuntux64, windowsx64]
190194
name: 'Publish Release'
191195
runs-on: ubuntu-latest
192196
steps:
@@ -205,6 +209,7 @@ jobs:
205209
${{github.workspace}}/artifacts/*/*.deb
206210
${{github.workspace}}/artifacts/*/*.pkg
207211
${{github.workspace}}/artifacts/*/*_setup.exe
212+
${{github.workspace}}/artifacts/*/*_Windows_x86_64.zip
208213
body_path: ${{github.workspace}}/changelog.md
209214
tag_name: ${{inputs.publish && inputs.tagname || github.ref_name}}
210215
name: ${{inputs.publish && inputs.tagname || github.ref_name}}

changelog.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
Either
1313
- Use the installer and select your OBS folder.
1414
or
15-
- Extract Waveform\_v#.#.#\_x86\_64.zip to the *root* of your OBS folder (e.g. `C:\Program Files (x86)\obs-studio`).
15+
- Extract Waveform\_v#.#.#\_Windows\_x86\_64.zip to the *root* of your OBS folder (e.g. `C:\Program Files\obs-studio`).
1616

17-
### Linux (Ubuntu 20.04, Flatpak)
17+
### Linux (Ubuntu 24.04, Flatpak)
1818
<details>
1919
<summary>Click for instructions</summary>
2020

@@ -30,10 +30,12 @@ or
3030
Note: Should work for most distros, but do not mix with the .deb package above.
3131
</details>
3232

33-
### MacOS (12.0+, OBS 28+)
33+
### MacOS
3434
<details>
3535
<summary>Click for instructions</summary>
3636

37+
**MacOS binaries are not signed, you will need to manually unblock them.**
38+
3739
#### Intel Macs
3840
- **Uninstall waveform versions prior to 1.6.0**
3941
- Download Waveform\_v#.#.#\_MacOS\_x86\_64.pkg and run it.

installer/installer.iss.in

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,20 @@ AppVersion={#MyAppVersion}
1515
AppPublisherURL={#MyAppURL}
1616
AppSupportURL={#MyAppURL}
1717
AppUpdatesURL={#MyAppURL}
18-
DefaultDirName={reg:HKLM\Software\OBS Studio,|{commonpf32}\obs-studio}
18+
DefaultDirName={reg:HKLM\Software\OBS Studio,|{commonpf64}\obs-studio}
1919
AppendDefaultDirName=no
2020
DirExistsWarning=no
2121
DefaultGroupName={#MyAppName}
2222
LicenseFile={#SourcePath}\..\LICENSE
2323
; Uncomment the following line to run in non administrative install mode (install for current user only.)
2424
;PrivilegesRequired=lowest
25-
OutputBaseFilename=Waveform_v{#MyAppVersion}_setup
25+
OutputBaseFilename=Waveform_v{#MyAppVersion}_Windows_x86_64_setup
2626
Compression=lzma
2727
SolidCompression=yes
2828
WizardStyle=modern
2929
Uninstallable=WizardIsTaskSelected('create_uninstaller')
3030
DisableDirPage=no
31+
SetupArchitecture=x64
3132

3233
[Languages]
3334
Name: "english"; MessagesFile: "compiler:Default.isl"

0 commit comments

Comments
 (0)