Skip to content

Commit 43b957a

Browse files
authored
Merge pull request #12 from Alokzh/fix-memory-parameter-issue
Fix memory parameter references in DataFrame vs Buffer benchmarks
2 parents dfe6f64 + 46da864 commit 43b957a

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

docs/DataFrame vs Buffer.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ Transcript show: 'Testing DataFrame approach...'; cr.
9292
| startTime endTime memoryBefore memoryAfter gcBefore gcAfter gcTimeBefore gcTimeAfter
9393
stockData priceColumn movingAverages |
9494
95-
memoryBefore := Smalltalk vm parameterAt: 3.
95+
memoryBefore := Smalltalk vm parameterAt: 34.
9696
gcBefore := (Smalltalk vm parameterAt: 7) + (Smalltalk vm parameterAt: 9).
9797
gcTimeBefore := (Smalltalk vm parameterAt: 8) + (Smalltalk vm parameterAt: 10).
9898
startTime := Time millisecondClockValue.
@@ -115,7 +115,7 @@ Transcript show: 'Testing DataFrame approach...'; cr.
115115
].
116116
117117
endTime := Time millisecondClockValue.
118-
memoryAfter := Smalltalk vm parameterAt: 3.
118+
memoryAfter := Smalltalk vm parameterAt: 34.
119119
gcAfter := (Smalltalk vm parameterAt: 7) + (Smalltalk vm parameterAt: 9).
120120
gcTimeAfter := (Smalltalk vm parameterAt: 8) + (Smalltalk vm parameterAt: 10).
121121
Transcript show: 'DataFrame Test Results:'; cr.
@@ -139,7 +139,7 @@ Transcript show: 'Testing Buffer approach...'; cr.
139139
[
140140
| startTime endTime memoryBefore memoryAfter gcBefore gcAfter gcTimeBefore gcTimeAfter priceBuffer movingAverages |
141141
142-
memoryBefore := Smalltalk vm parameterAt: 3.
142+
memoryBefore := Smalltalk vm parameterAt: 34.
143143
gcBefore := (Smalltalk vm parameterAt: 7) + (Smalltalk vm parameterAt: 9).
144144
gcTimeBefore := (Smalltalk vm parameterAt: 8) + (Smalltalk vm parameterAt: 10).
145145
startTime := Time millisecondClockValue.
@@ -172,7 +172,7 @@ Transcript show: 'Testing Buffer approach...'; cr.
172172
].
173173
174174
endTime := Time millisecondClockValue.
175-
memoryAfter := Smalltalk vm parameterAt: 3.
175+
memoryAfter := Smalltalk vm parameterAt: 34.
176176
gcAfter := (Smalltalk vm parameterAt: 7) + (Smalltalk vm parameterAt: 9).
177177
gcTimeAfter := (Smalltalk vm parameterAt: 8) + (Smalltalk vm parameterAt: 10).
178178
@@ -198,7 +198,7 @@ Here are the results from running this benchmark on a 8,000,000 row dataset (app
198198
| Metric | DataFrame | Circular Buffer | Improvement |
199199
|--------|-----------|-----------------|-------------|
200200
| **Execution Time** | ~968,804 ms | ~46,258 ms | **21x faster** |
201-
| **Memory Usage** | ~1,184 MB | ~112 MB | **10.6x less memory** |
201+
| **Memory Usage** | ~222,730 MB | ~14,148 MB | **16x less memory** |
202202
| **GC Events** | ~14,943 | ~944 | **94% fewer** |
203203
| **GC Time** | ~826,382 ms | ~405 ms | **2,040x less GC overhead** |
204204
| **Results Generated** | 7,999,901 | 7,999,901 | Identical accuracy |

0 commit comments

Comments
 (0)