Skip to content

Refactor buffer implementation to include FIFO & LIFO Variations#3

Merged
jordanmontt merged 6 commits into
pharo-containers:mainfrom
Alokxk:refactor-buffer-implementation
Jun 17, 2025
Merged

Refactor buffer implementation to include FIFO & LIFO Variations#3
jordanmontt merged 6 commits into
pharo-containers:mainfrom
Alokxk:refactor-buffer-implementation

Conversation

@Alokxk

@Alokxk Alokxk commented Jun 13, 2025

Copy link
Copy Markdown
Collaborator

Changes:

  • CTAbstractBuffer: Base class with common buffer functionality
  • CTFIFOBuffer: First-In-First-Out buffer (Queue behavior)
  • CTLIFOBuffer: Last-In-First-Out buffer (Stack behavior)

Testing:

  • Added Tests for both FIFO and LIFO behaviors in CTBufferTest class

@coveralls

coveralls commented Jun 13, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 15641247937

Details

  • 207 of 211 (98.1%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.8%) to 98.104%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 131 135 97.04%
Totals Coverage Status
Change from base Build 15580888910: 4.8%
Covered Lines: 207
Relevant Lines: 211

💛 - Coveralls

@Alokxk Alokxk force-pushed the refactor-buffer-implementation branch from a274d30 to 6a911de Compare June 13, 2025 17:33
@Alokxk Alokxk marked this pull request as ready for review June 13, 2025 18:18
@jordanmontt jordanmontt merged commit c1893b1 into pharo-containers:main Jun 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants