Skip to content

Refactor current tests to super & subclasses architecture#4

Merged
jordanmontt merged 3 commits into
pharo-containers:mainfrom
Alokxk:refactor-buffer-tests
Jun 18, 2025
Merged

Refactor current tests to super & subclasses architecture#4
jordanmontt merged 3 commits into
pharo-containers:mainfrom
Alokxk:refactor-buffer-tests

Conversation

@Alokxk
Copy link
Copy Markdown
Collaborator

@Alokxk Alokxk commented Jun 18, 2025

Changes

  • Extracted common buffer tests into CTAbstractBufferTest class
  • Created CTFIFOBufferTest and CTLIFOBufferTest subclasses
  • Refactored tests with CTAbstractBufferTest base class
  • Fixed copy method bug

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 18, 2025

Pull Request Test Coverage Report for Build 15727099160

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 25 of 25 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 98.238%

Totals Coverage Status
Change from base Build 15701747297: 0.1%
Covered Lines: 223
Relevant Lines: 227

💛 - Coveralls

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 15724913199

Details

  • 25 of 25 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 98.238%

Totals Coverage Status
Change from base Build 15701747297: 0.1%
Covered Lines: 223
Relevant Lines: 227

💛 - Coveralls

@jordanmontt jordanmontt merged commit 45ee086 into pharo-containers:main Jun 18, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants