Skip to content

Fix API to match OrderedCollection conventions for easy drop-in replacement#8

Merged
Alokxk merged 2 commits into
pharo-containers:mainfrom
Alokxk:fix/api-naming-conventions
Jul 3, 2025
Merged

Fix API to match OrderedCollection conventions for easy drop-in replacement#8
Alokxk merged 2 commits into
pharo-containers:mainfrom
Alokxk:fix/api-naming-conventions

Conversation

@Alokxk
Copy link
Copy Markdown
Collaborator

@Alokxk Alokxk commented Jul 3, 2025

Changes:

  • Replaced withCapacity: with new: pattern (matches OrderedCollection)
  • Replaced clear with removeAll (standard convention)
  • Updated tests and documentation

@Alokxk Alokxk merged commit 40a61f2 into pharo-containers:main Jul 3, 2025
12 checks passed
@Alokxk Alokxk deleted the fix/api-naming-conventions branch July 3, 2025 17:27
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2025

Pull Request Test Coverage Report for Build 16056838131

Details

  • 32 of 34 (94.12%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.1%) to 96.154%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 23 25 92.0%
Files with Coverage Reduction New Missed Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 3 93.23%
Totals Coverage Status
Change from base Build 15894909919: -2.1%
Covered Lines: 225
Relevant Lines: 234
💛 - Coveralls

12 similar comments
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2025

Pull Request Test Coverage Report for Build 16056838131

Details

  • 32 of 34 (94.12%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.1%) to 96.154%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 23 25 92.0%
Files with Coverage Reduction New Missed Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 3 93.23%
Totals Coverage Status
Change from base Build 15894909919: -2.1%
Covered Lines: 225
Relevant Lines: 234
💛 - Coveralls

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2025

Pull Request Test Coverage Report for Build 16056838131

Details

  • 32 of 34 (94.12%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.1%) to 96.154%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 23 25 92.0%
Files with Coverage Reduction New Missed Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 3 93.23%
Totals Coverage Status
Change from base Build 15894909919: -2.1%
Covered Lines: 225
Relevant Lines: 234
💛 - Coveralls

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2025

Pull Request Test Coverage Report for Build 16056838131

Details

  • 32 of 34 (94.12%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.1%) to 96.154%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 23 25 92.0%
Files with Coverage Reduction New Missed Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 3 93.23%
Totals Coverage Status
Change from base Build 15894909919: -2.1%
Covered Lines: 225
Relevant Lines: 234
💛 - Coveralls

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2025

Pull Request Test Coverage Report for Build 16056838131

Details

  • 32 of 34 (94.12%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.1%) to 96.154%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 23 25 92.0%
Files with Coverage Reduction New Missed Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 3 93.23%
Totals Coverage Status
Change from base Build 15894909919: -2.1%
Covered Lines: 225
Relevant Lines: 234
💛 - Coveralls

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2025

Pull Request Test Coverage Report for Build 16056838131

Details

  • 32 of 34 (94.12%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.1%) to 96.154%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 23 25 92.0%
Files with Coverage Reduction New Missed Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 3 93.23%
Totals Coverage Status
Change from base Build 15894909919: -2.1%
Covered Lines: 225
Relevant Lines: 234
💛 - Coveralls

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2025

Pull Request Test Coverage Report for Build 16056838131

Details

  • 32 of 34 (94.12%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.1%) to 96.154%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 23 25 92.0%
Files with Coverage Reduction New Missed Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 3 93.23%
Totals Coverage Status
Change from base Build 15894909919: -2.1%
Covered Lines: 225
Relevant Lines: 234
💛 - Coveralls

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2025

Pull Request Test Coverage Report for Build 16056838131

Details

  • 32 of 34 (94.12%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.1%) to 96.154%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 23 25 92.0%
Files with Coverage Reduction New Missed Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 3 93.23%
Totals Coverage Status
Change from base Build 15894909919: -2.1%
Covered Lines: 225
Relevant Lines: 234
💛 - Coveralls

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2025

Pull Request Test Coverage Report for Build 16056838131

Details

  • 32 of 34 (94.12%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.1%) to 96.154%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 23 25 92.0%
Files with Coverage Reduction New Missed Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 3 93.23%
Totals Coverage Status
Change from base Build 15894909919: -2.1%
Covered Lines: 225
Relevant Lines: 234
💛 - Coveralls

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2025

Pull Request Test Coverage Report for Build 16056838131

Details

  • 32 of 34 (94.12%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.1%) to 96.154%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 23 25 92.0%
Files with Coverage Reduction New Missed Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 3 93.23%
Totals Coverage Status
Change from base Build 15894909919: -2.1%
Covered Lines: 225
Relevant Lines: 234
💛 - Coveralls

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2025

Pull Request Test Coverage Report for Build 16056838131

Details

  • 32 of 34 (94.12%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.1%) to 96.154%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 23 25 92.0%
Files with Coverage Reduction New Missed Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 3 93.23%
Totals Coverage Status
Change from base Build 15894909919: -2.1%
Covered Lines: 225
Relevant Lines: 234
💛 - Coveralls

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2025

Pull Request Test Coverage Report for Build 16056838131

Details

  • 32 of 34 (94.12%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.1%) to 96.154%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 23 25 92.0%
Files with Coverage Reduction New Missed Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 3 93.23%
Totals Coverage Status
Change from base Build 15894909919: -2.1%
Covered Lines: 225
Relevant Lines: 234
💛 - Coveralls

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 3, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 16056838131

Details

  • 32 of 34 (94.12%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.1%) to 96.154%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 23 25 92.0%
Files with Coverage Reduction New Missed Lines %
src/Containers-Buffer/CTAbstractBuffer.class.st 3 93.23%
Totals Coverage Status
Change from base Build 15894909919: -2.1%
Covered Lines: 225
Relevant Lines: 234
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alokxk @coveralls