fix: use stable tmux pane targets#69
Merged
Merged
Conversation
|
🎉 This PR is included in version 0.19.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Fix tmux backend failures for project directories whose tmux window names contain target syntax characters such as dots. A window named
dr-remote.jpwas being passed to tmux assession:dr-remote.jp; tmux interpreted.jpas a pane selector, so mirror refresh reported[tmux pane closed]even though the pane was alive.Also restore the expected workspace ergonomics: after setup or workspace switching, apply the current project's example window layout automatically when
enkan-repl-setup-current-project-layoutis loaded.Finally, handle layout resolution when a session entry uses an alias whose real project name differs, such as
er->enkan-repl.Changes
%pane_idin enkan tmux identifiers when available.send-keys,capture-pane, cwd lookup, kill, and alert capture to%pane_id.session:windowIDs for existing state and tests.Test plan
make test(274 tests)make compileexamples/window-layouts.elwith warnings as errorsenkan-repl-workspace-list.elwith warnings as errorstest-enkan-repl--terminal-tmux-start-dotted-window-uses-pane-idtest-enkan-repl--terminal-tmux--capture-pane-async-targets-pane-idtest-enkan-repl-setup-creates-workspace-standard-filetest-enkan-repl-setup-creates-workspace-center-filetest-enkan-repl-workspace-switch-runs-current-project-layouttest-workspace-list-switch-runs-current-project-layouttest-workspace-delete-current-runs-current-project-layouttest-workspace-layout-resolves-session-alias-to-project-name/Users/sekine/dev/offisis/dr-remote.jp/, got idenkan-fix-test-97:dr-remote.jp|%29, verified capture via target%29.