Skip to content
This repository was archived by the owner on Jan 30, 2024. It is now read-only.

Replace Fixnum references#232

Closed
3zcurdia wants to merge 2 commits into
phatworx:masterfrom
CambiaHPW:replace-fixnum
Closed

Replace Fixnum references#232
3zcurdia wants to merge 2 commits into
phatworx:masterfrom
CambiaHPW:replace-fixnum

Conversation

@3zcurdia
Copy link
Copy Markdown

It replaces references Fixnum references from ruby 2.4.
It closes #231

@3zcurdia 3zcurdia force-pushed the replace-fixnum branch 5 times, most recently from c48cdc7 to 1620a72 Compare December 19, 2017 18:11
@3zcurdia 3zcurdia force-pushed the replace-fixnum branch 2 times, most recently from d550ac0 to b0c62ae Compare December 19, 2017 18:52
@Gasparila
Copy link
Copy Markdown

@alexdreher any way we can get this merged?

@vimutter
Copy link
Copy Markdown

@3zcurdia I think you need to update Gemfile for 2.4. Do you need help with that?

@erolms
Copy link
Copy Markdown

erolms commented Apr 12, 2018

Folks, when can we get this commit merged into master?

@Gasparila
Copy link
Copy Markdown

Until this is merged, we "fixed" the deprecation warnings by adding Devise::Models::PasswordArchivable.const_set("Fixnum", Integer) to the devise initializer file

@erolms
Copy link
Copy Markdown

erolms commented Apr 13, 2018

In my case I had to add Devise::Models::PasswordExpirable.const_set("Fixnum", Integer) too. Working like a charm, thanks!

@tibbon
Copy link
Copy Markdown

tibbon commented Jul 26, 2018

What's the status of this?

@3zcurdia
Copy link
Copy Markdown
Author

closing this PR in favor of #238

@3zcurdia 3zcurdia closed this Aug 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fixnum is deprecated as of Ruby 2.4.0

5 participants