fix: stale live preview position preference cache

Author: devvaannsh

src/LiveDevelopment/main.js

@@ -73,7 +73,7 @@ define(function main(require, exports, module) {
         showRulerLines: false, // default value, this will get updated when the extension loads
         showStylesBar: true, // default value, this will get updated when the extension loads
         showStarterBar: true, // default value, this will get updated when the extension loads
-        stylesBarPosition: "", // saved dock side ("top"/"bottom"); empty = default bottom
+        stylesBarPosition: "bottom", // saved dock side ("top"/"bottom")
         syncSourceAndPreview: true, // default value, this will get updated when the extension loads
         imageGalleryAutoOpen: true, // auto-open gallery on first image click per session
         isPaidUser: false, // will be updated when we fetch entitlements
@@ -356,7 +356,7 @@ define(function main(require, exports, module) {
     function updateStylesBarPositionConfig() {
         const prefValue = PreferencesManager.get(CONSTANTS.PREFERENCE_STYLES_BAR_POSITION);
         const config = MultiBrowserLiveDev.getConfig();
-        config.stylesBarPosition = prefValue || "";
+        config.stylesBarPosition = prefValue || "bottom";
         MultiBrowserLiveDev.updateConfig(config);
     }
 

src/extensionsIntegrated/Phoenix-live-preview/main.js

@@ -127,10 +127,11 @@ define(function (require, exports, module) {
         description: Strings.LIVE_DEV_SETTINGS_SHOW_STARTER_BAR_PREFERENCE
     });
 
-    // live preview styles bar position preference; persists where the user last dragged the bar
+    // live preview styles bar dock side preference; persisted when the user flips the bar's dock button
     const PREFERENCE_STYLES_BAR_POSITION = CONSTANTS.PREFERENCE_STYLES_BAR_POSITION;
-    PreferencesManager.definePreference(PREFERENCE_STYLES_BAR_POSITION, "string", "", {
-        description: Strings.LIVE_DEV_SETTINGS_STYLES_BAR_POSITION_PREFERENCE
+    PreferencesManager.definePreference(PREFERENCE_STYLES_BAR_POSITION, "string", "bottom", {
+        description: Strings.LIVE_DEV_SETTINGS_STYLES_BAR_POSITION_PREFERENCE,
+        values: ["top", "bottom"]
     });
 
     const LIVE_PREVIEW_PANEL_ID = "live-preview-panel";

src/nls/root/strings.js

@@ -185,7 +185,7 @@ define({
     "LIVE_DEV_SETTINGS_SHOW_RULER_LINES_PREFERENCE": "Show measurements when elements are selected in live preview. Defaults to 'false'",
     "LIVE_DEV_SETTINGS_SHOW_STYLES_BAR_PREFERENCE": "Show the styles bar when elements are selected in live preview. Defaults to 'true'",
     "LIVE_DEV_SETTINGS_SHOW_STARTER_BAR_PREFERENCE": "Show the starter bar when the live preview page is empty. Defaults to 'true'",
-    "LIVE_DEV_SETTINGS_STYLES_BAR_POSITION_PREFERENCE": "Saved position of the live preview styles bar, set automatically when the bar is dragged. Empty places the bar at its default spot",
+    "LIVE_DEV_SETTINGS_STYLES_BAR_POSITION_PREFERENCE": "Which edge the live preview styles bar docks to, 'top' or 'bottom'. Defaults to 'bottom'",
     "LIVE_DEV_TOOLBOX_SELECT_PARENT": "Select Parent",
     "LIVE_DEV_TOOLBOX_EDIT_TEXT": "Edit Text",
     "LIVE_DEV_TOOLBOX_DOUBLE_CLICK_HINT": "Double-click",