fix: dont remove the element highlighting when selected from a css selector

Author: devvaannsh

src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

@@ -33,7 +33,7 @@ function RemoteFunctions(config = {}) {
     let _clickHighlight;
     let _cssSelectorHighlight; // temporary highlight for CSS selector matches in edit mode
     let _hoverLockTimer = null;
-    let _cssSelectorHighlightTimer = null; // timer for clearing temporary CSS selector highlights
+    let _cssSelectorHighlightTimer = null;
 
     // this will store the element that was clicked previously (before the new click)
     // we need this so that we can remove click styling from the previous element when a new element is clicked
@@ -642,7 +642,7 @@ function RemoteFunctions(config = {}) {
         selectElement(element);
     }
 
-    // clear temporary CSS selector highlights
+    // clear CSS selector highlights
     function clearCssSelectorHighlight() {
         if (_cssSelectorHighlightTimer) {
             clearTimeout(_cssSelectorHighlightTimer);
@@ -661,31 +661,26 @@ function RemoteFunctions(config = {}) {
         }
     }
 
-    // create temporary CSS selector highlights for edit mode
+    // create CSS selector highlights for edit mode
     function createCssSelectorHighlight(nodes, rule) {
-        // Clear any existing temporary highlights
+        // Clear any existing highlights
         clearCssSelectorHighlight();
 
-        // Create new temporary highlight for all matching elements
-        // Skip the selected element since it already has a click highlight
+        // Highlight all matching elements except the selected one
+        // (it already has a click highlight)
         _cssSelectorHighlight = new Highlight();
         for (let i = 0; i < nodes.length; i++) {
             if (nodes[i] !== previouslySelectedElement &&
                 LivePreviewView.isElementInspectable(nodes[i], true) &&
                 nodes[i].nodeType === Node.ELEMENT_NODE) {
                 _cssSelectorHighlight.add(nodes[i]);
-                // Apply outline to all matching elements so they are visible
-                // even when they have no margin/padding
                 nodes[i]._originalCssSelectorOutline = nodes[i].style.outline;
                 const isEditable = nodes[i].hasAttribute(GLOBALS.DATA_BRACKETS_ID_ATTR);
                 const outlineColor = isEditable ? COLORS.outlineEditable : COLORS.outlineNonEditable;
                 nodes[i].style.outline = `1px solid ${outlineColor}`;
             }
         }
         _cssSelectorHighlight.selector = rule;
-
-        // Clear temporary highlights after 2 seconds
-        _cssSelectorHighlightTimer = setTimeout(clearCssSelectorHighlight, 2000);
     }
 
     // remove active highlights

src/nls/root/strings.js

@@ -266,13 +266,6 @@ define({
     "LIVE_DEV_ELEMENT_PROPS_COMPUTED": "Computed:",
     "LIVE_DEV_ELEMENT_PROPS_USE_CUSTOM": "Use \u201c{0}\u201d",
     "LIVE_DEV_CB_EXCEEDED_CLASSES": "+{0} more",
-    "LIVE_DEV_CB_TITLE_FONT": "Font",
-    "LIVE_DEV_CB_TITLE_SPACING": "Spacing",
-    "LIVE_DEV_CB_TITLE_BORDER": "Border",
-    "LIVE_DEV_CB_TITLE_EFFECTS": "Effects",
-    "LIVE_DEV_CB_TITLE_LAYOUT": "Layout",
-    "LIVE_DEV_CB_TITLE_OBJECT_FIT": "Object Fit",
-    "LIVE_DEV_CB_TITLE_LIST_STYLE": "List Style",
     "LIVE_DEV_CB_TIP_TEXT_COLOR": "Text Color",
     "LIVE_DEV_CB_TIP_BG_COLOR": "Background Color",
     "LIVE_DEV_CB_TIP_FONT": "Font",
@@ -347,7 +340,6 @@ define({
     "LIVE_DEV_CB_LIST_UPPER_ROMAN": "Upper Roman",
     "LIVE_DEV_CB_LIST_OUTSIDE": "Outside",
     "LIVE_DEV_CB_LIST_INSIDE": "Inside",
-    "LIVE_DEV_CB_TITLE_SPACING_BOX": "Spacing",
     "LIVE_DEV_CB_TIP_SPACING": "Margin & Padding",
     "LIVE_DEV_CB_LABEL_MARGIN": "Margin",
     "LIVE_DEV_CB_LABEL_PADDING": "Padding",
@@ -363,6 +355,9 @@ define({
     "LIVE_DEV_CB_PER_CORNER": "Per corner",
     "LIVE_DEV_CB_SHADOW_ADD": "Add Shadow",
     "LIVE_DEV_CB_SHADOW_INSET": "Inset",
+    "LIVE_DEV_CB_COLOR_RECENT": "Recent",
+    "LIVE_DEV_CB_COLOR_FROM_PAGE": "From page",
+    "LIVE_DEV_CB_COLOR_SUGGESTED": "Suggested",
     "LIVE_DEV_CB_LABEL_COLUMNS": "Columns",
     "LIVE_DEV_CB_LABEL_ROWS": "Rows",
     "LIVE_DEV_CB_LABEL_JUSTIFY_ITEMS": "Justify",