feat: confirm before opening a large number of changed files

Author: devvaannsh

src/extensions/default/Git/src/Panel.js

@@ -1016,6 +1016,28 @@ define(function (require, exports) {
             });
     }
 
+    const OPEN_ALL_CONFIRM_THRESHOLD = 50;
+
+    function _openChangedFiles(files) {
+        const currentGitRoot = Preferences.get("currentGitRoot");
+        // addListToWorkingSet ignores files already present in any pane, so this is safe
+        // to run repeatedly or with some of the files already open
+        const fileList = files.map(function (file) {
+            return FileSystem.getFileForPath(currentGitRoot + file.file);
+        });
+        MainViewManager.addListToWorkingSet(MainViewManager.ACTIVE_PANE, fileList);
+
+        // if the user is already viewing one of the changed files, we don't switch the file then...
+        // if user is viewing a un-changed file, then we switch to the first changed file
+        const currentPath = MainViewManager.getCurrentlyViewedPath(MainViewManager.ACTIVE_PANE);
+        const viewingChangedFile = _.any(fileList, function (file) {
+            return file.fullPath === currentPath;
+        });
+        if (!viewingChangedFile) {
+            CommandManager.execute(Commands.FILE_OPEN, { fullPath: fileList[0].fullPath });
+        }
+    }
+
     function openAllChangedFiles() {
         return Git.status().then(function (files) {
             files = _.filter(files, function (file) {
@@ -1037,23 +1059,18 @@ define(function (require, exports) {
                 return;
             }
 
-            const currentGitRoot = Preferences.get("currentGitRoot");
-            // addListToWorkingSet ignores files already present in any pane, so this is safe
-            // to run repeatedly or with some of the files already open
-            const fileList = files.map(function (file) {
-                return FileSystem.getFileForPath(currentGitRoot + file.file);
-            });
-            MainViewManager.addListToWorkingSet(MainViewManager.ACTIVE_PANE, fileList);
-
-            // if the user is already viewing one of the changed files, we don't switch the file then...
-            // if user is viewing a un-changed file, then we switch to the first changed file
-            const currentPath = MainViewManager.getCurrentlyViewedPath(MainViewManager.ACTIVE_PANE);
-            const viewingChangedFile = _.any(fileList, function (file) {
-                return file.fullPath === currentPath;
-            });
-            if (!viewingChangedFile) {
-                CommandManager.execute(Commands.FILE_OPEN, { fullPath: fileList[0].fullPath });
+            if (files.length > OPEN_ALL_CONFIRM_THRESHOLD) {
+                return Utils.askQuestion(Strings.CMD_OPEN_CHANGED_FILES,
+                    StringUtils.format(Strings.OPEN_CHANGED_FILES_CONFIRM, files.length),
+                    { booleanResponse: true })
+                    .then(function (response) {
+                        if (response === true) {
+                            _openChangedFiles(files);
+                        }
+                    });
             }
+
+            _openChangedFiles(files);
         }).catch(function (err) {
             ErrorHandler.showError(err, Strings.ERROR_OPENING_CHANGED_FILES);
         });

src/nls/root/strings.js

@@ -2171,6 +2171,7 @@ define({
     "MERGE_RESULT": "Merge result",
     "NORMALIZE_LINE_ENDINGS": "Normalize line endings (to \\n)",
     "NOTHING_TO_COMMIT": "Nothing to commit, working directory clean.",
+    "OPEN_CHANGED_FILES_CONFIRM": "This will open {0} files in the editor. Do you want to continue?",
     "OPERATION_IN_PROGRESS_TITLE": "Git operation in progress\u2026",
     "ORIGIN_BRANCH": "Origin branch",
     "ON_BRANCH": "'{0}' - Current Git branch",