Skip to content

Commit 8db6786

Browse files
devvaannshabose
authored andcommitted
feat: add option to toggle visibility of styles bar
1 parent eadc513 commit 8db6786

4 files changed

Lines changed: 27 additions & 1 deletion

File tree

src/LiveDevelopment/LivePreviewConstants.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,6 @@ define(function main(require, exports, module) {
4141
exports.HIGHLIGHT_CLICK = "click";
4242

4343
exports.PREFERENCE_SHOW_RULER_LINES = "livePreviewShowMeasurements";
44+
45+
exports.PREFERENCE_SHOW_STYLES_BAR = "livePreviewShowStylesBar";
4446
});

src/LiveDevelopment/main.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ define(function main(require, exports, module) {
7171
mode: LIVE_HIGHLIGHT_MODE, // will be updated when we fetch entitlements
7272
elemHighlights: CONSTANTS.HIGHLIGHT_HOVER, // default value, this will get updated when the extension loads
7373
showRulerLines: false, // default value, this will get updated when the extension loads
74+
showStylesBar: true, // default value, this will get updated when the extension loads
7475
syncSourceAndPreview: true, // default value, this will get updated when the extension loads
7576
imageGalleryAutoOpen: true, // auto-open gallery on first image click per session
7677
isPaidUser: false, // will be updated when we fetch entitlements
@@ -336,6 +337,13 @@ define(function main(require, exports, module) {
336337
MultiBrowserLiveDev.updateConfig(config);
337338
}
338339

340+
function updateStylesBarConfig() {
341+
const prefValue = PreferencesManager.get(CONSTANTS.PREFERENCE_SHOW_STYLES_BAR);
342+
const config = MultiBrowserLiveDev.getConfig();
343+
config.showStylesBar = prefValue !== false; // defaults to true (on)
344+
MultiBrowserLiveDev.updateConfig(config);
345+
}
346+
339347
EventDispatcher.makeEventDispatcher(exports);
340348

341349
// private api
@@ -359,6 +367,7 @@ define(function main(require, exports, module) {
359367
exports.setLivePreviewTransportBridge = setLivePreviewTransportBridge;
360368
exports.updateElementHighlightConfig = updateElementHighlightConfig;
361369
exports.updateRulerLinesConfig = updateRulerLinesConfig;
370+
exports.updateStylesBarConfig = updateStylesBarConfig;
362371
exports.getConnectionIds = MultiBrowserLiveDev.getConnectionIds;
363372
exports.getLivePreviewDetails = MultiBrowserLiveDev.getLivePreviewDetails;
364373
exports.hideHighlight = MultiBrowserLiveDev.hideHighlight;

src/extensionsIntegrated/Phoenix-live-preview/main.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,12 @@ define(function (require, exports, module) {
115115
description: Strings.LIVE_DEV_SETTINGS_SHOW_RULER_LINES_PREFERENCE
116116
});
117117

118+
// live preview styles bar preference (show/hide the styles bar on element selection); on by default
119+
const PREFERENCE_SHOW_STYLES_BAR = CONSTANTS.PREFERENCE_SHOW_STYLES_BAR;
120+
PreferencesManager.definePreference(PREFERENCE_SHOW_STYLES_BAR, "boolean", true, {
121+
description: Strings.LIVE_DEV_SETTINGS_SHOW_STYLES_BAR_PREFERENCE
122+
});
123+
118124
const LIVE_PREVIEW_PANEL_ID = "live-preview-panel";
119125
const LIVE_PREVIEW_IFRAME_ID = "panel-live-preview-frame";
120126
const MDVIEWR_IFRAME_ID = "panel-md-preview-frame";
@@ -1540,9 +1546,13 @@ define(function (require, exports, module) {
15401546
PreferencesManager.on("change", PREFERENCE_SHOW_RULER_LINES, function() {
15411547
LiveDevelopment.updateRulerLinesConfig();
15421548
});
1543-
// Initialize element highlight and ruler lines config on startup
1549+
PreferencesManager.on("change", PREFERENCE_SHOW_STYLES_BAR, function() {
1550+
LiveDevelopment.updateStylesBarConfig();
1551+
});
1552+
// Initialize element highlight, ruler lines and styles bar config on startup
15441553
LiveDevelopment.updateElementHighlightConfig();
15451554
LiveDevelopment.updateRulerLinesConfig();
1555+
LiveDevelopment.updateStylesBarConfig();
15461556

15471557
LiveDevelopment.openLivePreview();
15481558
LiveDevelopment.on(LiveDevelopment.EVENT_OPEN_PREVIEW_URL, _openLivePreviewURL);

src/nls/root/strings.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,7 @@ define({
183183
"LIVE_DEV_SETTINGS_FRAMEWORK_PREFERENCES": "Server Framework, currently supports only docusaurus",
184184
"LIVE_DEV_SETTINGS_ELEMENT_HIGHLIGHT_PREFERENCE": "Inspect element in Live Preview on 'hover' or 'click'. Defaults to 'hover'",
185185
"LIVE_DEV_SETTINGS_SHOW_RULER_LINES_PREFERENCE": "Show measurements when elements are selected in live preview. Defaults to 'false'",
186+
"LIVE_DEV_SETTINGS_SHOW_STYLES_BAR_PREFERENCE": "Show the styles bar when elements are selected in live preview. Defaults to 'true'",
186187
"LIVE_DEV_TOOLBOX_SELECT_PARENT": "Select Parent",
187188
"LIVE_DEV_TOOLBOX_EDIT_TEXT": "Edit Text",
188189
"LIVE_DEV_TOOLBOX_DOUBLE_CLICK_HINT": "Double-click",
@@ -205,8 +206,11 @@ define({
205206
"LIVE_DEV_STYLER_SPACING": "Margin & padding",
206207
"LIVE_DEV_STYLER_LAYOUT": "Layout",
207208
"LIVE_DEV_STYLER_TEXT_STYLE": "Text style",
209+
"LIVE_DEV_STYLER_DOCK": "Dock position",
208210
"LIVE_DEV_STYLER_DOCK_TOP": "Move bar to top",
209211
"LIVE_DEV_STYLER_DOCK_BOTTOM": "Move bar to bottom",
212+
"LIVE_DEV_STYLER_DOCK_LEFT": "Move bar to left",
213+
"LIVE_DEV_STYLER_DOCK_RIGHT": "Move bar to right",
210214
"LIVE_DEV_STYLER_RESET": "Reset changes",
211215
"LIVE_DEV_STYLER_NOTHING_TO_RESET": "No changes to reset",
212216
"LIVE_DEV_STYLER_CLOSE_SAVED": "Done",
@@ -710,6 +714,7 @@ define({
710714
"LIVE_PREVIEW_MODE_EDIT": "Edit Mode",
711715
"LIVE_PREVIEW_EDIT_HIGHLIGHT_ON": "Inspect Element on Hover",
712716
"LIVE_PREVIEW_SHOW_RULER_LINES": "Show Measurements",
717+
"LIVE_PREVIEW_SHOW_STYLES_BAR": "Show Styles Bar",
713718
"LIVE_PREVIEW_MODE_PREFERENCE": "'{0}' shows only the webpage, '{1}' connects the webpage to your code - click on elements to jump to their code and vice versa, '{2}' provides highlighting along with advanced element manipulation",
714719
"LIVE_PREVIEW_CONFIGURE_MODES": "Configure Live Preview Modes",
715720

0 commit comments

Comments
 (0)