Commit a825095
committed
fix(phoenix-tour): expand sidebar before each step
Upgrade flows can boot Phoenix with the sidebar hidden (restored from a
previous session), which hides the AI tab (step 2) and the new-project
button (step 3) the tour points at. Because both are visibility:hidden
rather than display:none, getBoundingClientRect still returns positive
dimensions, so the existing rect-zero gate in _trackTarget didn't catch
this — the overlay would silently point at invisible UI.
Verified the failure mode and the fix in a connected electron instance:
the AI tab and new-project button switch from visibility:hidden to
visibility:visible after SidebarView.show().1 parent 023c571 commit a825095
1 file changed
Lines changed: 17 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| 35 | + | |
35 | 36 | | |
36 | 37 | | |
37 | 38 | | |
| |||
189 | 190 | | |
190 | 191 | | |
191 | 192 | | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
192 | 206 | | |
| 207 | + | |
193 | 208 | | |
194 | 209 | | |
195 | 210 | | |
| |||
235 | 250 | | |
236 | 251 | | |
237 | 252 | | |
| 253 | + | |
238 | 254 | | |
239 | 255 | | |
240 | 256 | | |
| |||
260 | 276 | | |
261 | 277 | | |
262 | 278 | | |
| 279 | + | |
263 | 280 | | |
264 | 281 | | |
265 | 282 | | |
| |||
0 commit comments