feat: allow disable commands handling by taking the pinned tabs into account

Author: devvaannsh

src/extensions/default/CloseOthers/main.js

@@ -92,20 +92,22 @@ define(function (require, exports, module) {
         CommandManager.get(closeAll).setName(Strings.CMD_FILE_CLOSE_ALL);
 
         if (file) {
-            var targetIndex  = MainViewManager.findInWorkingSet(MainViewManager.ACTIVE_PANE, file.fullPath),
-                workingSetListSize = MainViewManager.getWorkingSetSize(MainViewManager.ACTIVE_PANE);
-
-            if (targetIndex === workingSetListSize - 1) { // hide "Close Others Below" if the last file in Working Files is selected
-                CommandManager.get(closeBelow).setEnabled(false);
-            } else {
-                CommandManager.get(closeBelow).setEnabled(true);
-            }
-
-            if (targetIndex === 0) { // hide "Close Others Above" if the first file in Working Files is selected
-                CommandManager.get(closeAbove).setEnabled(false);
-            } else {
-                CommandManager.get(closeAbove).setEnabled(true);
-            }
+            let workingSetList = MainViewManager.getWorkingSet(MainViewManager.ACTIVE_PANE),
+                targetIndex = MainViewManager.findInWorkingSet(MainViewManager.ACTIVE_PANE, file.fullPath),
+                lastIndex = workingSetList.length - 1;
+
+            // we disable the bulk closing menu items if there are no files to close
+            // so for "Close Above", if the first file is selected or all files above are pinned
+            // for "Close Below", if the last file is selected or all files below are pinned
+            // for "Close All", if all files are pinned
+            let isPrevFilePinned = targetIndex > 0 &&
+                MainViewManager.isPathPinned(MainViewManager.ACTIVE_PANE, workingSetList[targetIndex - 1].fullPath);
+            let isLastFilePinned = lastIndex >= 0 &&
+                MainViewManager.isPathPinned(MainViewManager.ACTIVE_PANE, workingSetList[lastIndex].fullPath);
+
+            CommandManager.get(closeAbove).setEnabled(targetIndex > 0 && !isPrevFilePinned);
+            CommandManager.get(closeBelow).setEnabled(targetIndex < lastIndex && !isLastFilePinned);
+            CommandManager.get(closeAll).setEnabled(!isLastFilePinned);
         }
     }
 

src/extensionsIntegrated/TabBar/more-options.js

@@ -64,17 +64,26 @@ define(function (require, exports, module) {
         closeBelowCmd.setName(Strings.CLOSE_TABS_TO_THE_RIGHT);
         closeAllCmd.setName(Strings.CLOSE_ALL_TABS);
 
-        // Enable/disable Close Left/Right based on tab position
+        // Enable/disable Close Left/Right/All based on tab position and pinned files
+        const workingSetList = MainViewManager.getWorkingSet(_currentTabContext.paneId);
         const targetIndex = MainViewManager.findInWorkingSet(
             _currentTabContext.paneId,
             _currentTabContext.filePath
         );
-        const workingSetListSize = MainViewManager.getWorkingSetSize(_currentTabContext.paneId);
+        const lastIndex = workingSetList.length - 1;
 
-        // disable "Close Tabs to the Left" if this is the first tab
-        closeAboveCmd.setEnabled(targetIndex > 0);
-        // disable "Close Tabs to the Right" if this is the last tab
-        closeBelowCmd.setEnabled(targetIndex < workingSetListSize - 1);
+        // we disable the bulk closing menu items if there are no files to close
+        // for 'Close Tabs to the Left', if the first tab is selected or all tabs to the left are pinned
+        // for 'Close Tabs to the Right', if the last tab is selected or all tabs to the right are pinned
+        // for 'Close All Tabs', if all tabs are pinned
+        const isPrevTabPinned = targetIndex > 0 &&
+            MainViewManager.isPathPinned(_currentTabContext.paneId, workingSetList[targetIndex - 1].fullPath);
+        const isLastTabPinned = lastIndex >= 0 &&
+            MainViewManager.isPathPinned(_currentTabContext.paneId, workingSetList[lastIndex].fullPath);
+
+        closeAboveCmd.setEnabled(targetIndex > 0 && !isPrevTabPinned);
+        closeBelowCmd.setEnabled(targetIndex < lastIndex && !isLastTabPinned);
+        closeAllCmd.setEnabled(!isLastTabPinned);
     }
 
     /**