refactor: truncate branch name once for sidebar and panel

Author: devvaannsh

src/extensions/default/Git/src/Branch.js

@@ -516,18 +516,19 @@ define(function (require, exports) {
 
                     EventEmitter.emit(Events.REBASE_MERGE_MODE, mergeInfo.rebaseMode, mergeInfo.mergeMode);
 
-                    var MAX_LEN = 18;
+                    const MAX_LEN = 18;
 
                     const tooltip = StringUtils.format(Strings.ON_BRANCH, branchName);
-                    const html = `<i class="fas fa-code-branch"></i> ${
-                        branchName.length > MAX_LEN ? branchName.substring(0, MAX_LEN) + "\u2026" : branchName
-                    }`;
+                    const displayName = branchName.length > MAX_LEN
+                        ? branchName.substring(0, MAX_LEN) + "\u2026"
+                        : branchName;
+                    const html = `<i class="fas fa-code-branch"></i> ${displayName}`;
                     $gitBranchName
                         .html(html)
                         .attr("title", tooltip)
                         .off("click")
                         .on("click", toggleDropdown);
-                    Panel.setBranchName(branchName, tooltip);
+                    Panel.setBranchName(displayName, tooltip);
                     $("#git-panel .git-panel-branch")
                         .addClass("clickable")
                         .off("click")

src/extensions/default/Git/src/Panel.js

@@ -852,17 +852,12 @@ define(function (require, exports) {
         }
     }
 
-    const BRANCH_MAX_LEN = 18;
-
-    // called by Branch.refresh() so the panel indicator always mirrors the sidebar one,
-    // including merge/rebase decorations like "main|MERGING"
+    // called by Branch.refresh() with the already truncated display name so the panel
+    // indicator always mirrors the sidebar one, including decorations like "main|MERGING"
     function setBranchName(branchName, tooltip) {
-        const displayName = branchName.length > BRANCH_MAX_LEN
-            ? branchName.substring(0, BRANCH_MAX_LEN) + "\u2026"
-            : branchName;
         const $branch = $gitPanel.find(".git-panel-branch");
         $branch.attr("title", tooltip || "");
-        $branch.find(".git-branch-name").text(displayName);
+        $branch.find(".git-branch-name").text(branchName);
     }
 
     function refreshCommitCounts() {