fix: quick access option gets stuck in selected state

Author: devvaannsh

src/extensions/default/Git/src/Panel.js

@@ -1510,6 +1510,21 @@ define(function (require, exports) {
             CommandManager.get(Constants.CMD_GIT_TOGGLE_PANEL).setChecked(false);
             Preferences.set("panelEnabled", false);
         }
+        // When the bottom panel container is collapsed, deselect the icon
+        // but don't save preference — the panel is still logically open.
+        if (panelID === WorkspaceManager.DEFAULT_PANEL_ID && Main.$icon) {
+            Main.$icon.toggleClass("on", false);
+            Main.$icon.toggleClass("selected-button", false);
+        }
+    });
+
+    // When any bottom panel is shown (container is visible),
+    // re-select the git icon if git panel is still open.
+    WorkspaceManager.on(WorkspaceManager.EVENT_WORKSPACE_PANEL_SHOWN, function (event, panelID) {
+        if (Main.$icon && Preferences.get("panelEnabled")) {
+            Main.$icon.toggleClass("on", true);
+            Main.$icon.toggleClass("selected-button", true);
+        }
     });
 
     exports.init = init;

src/extensionsIntegrated/CustomSnippets/main.js

@@ -255,14 +255,33 @@ define(function (require, exports, module) {
         });
     }
 
+    // Track whether the snippets panel has an open tab (survives container collapse).
+    let _snippetsTabOpen = false;
+
     // When the panel tab is closed externally (e.g. via the × button),
     // update the menu checked state to stay in sync.
     WorkspaceManager.on(WorkspaceManager.EVENT_WORKSPACE_PANEL_HIDDEN, function (event, panelID) {
         if (panelID === PANEL_ID && customSnippetsPanel) {
+            _snippetsTabOpen = false;
+            CommandManager.get(MY_COMMAND_ID).setChecked(false);
+        }
+        // Container collapsed — uncheck menu item but keep tab-open flag
+        if (panelID === WorkspaceManager.DEFAULT_PANEL_ID) {
             CommandManager.get(MY_COMMAND_ID).setChecked(false);
         }
     });
 
+    // When any bottom panel is shown (container is visible),
+    // re-check menu item if snippets panel still has an open tab.
+    WorkspaceManager.on(WorkspaceManager.EVENT_WORKSPACE_PANEL_SHOWN, function (event, panelID) {
+        if (panelID === PANEL_ID) {
+            _snippetsTabOpen = true;
+        }
+        if (_snippetsTabOpen) {
+            CommandManager.get(MY_COMMAND_ID).setChecked(true);
+        }
+    });
+
     AppInit.appReady(function () {
         CommandManager.register(MENU_ITEM_NAME, MY_COMMAND_ID, showCustomSnippetsPanel);
         // Render template with localized strings

src/extensionsIntegrated/DisplayShortcuts/main.js

@@ -539,14 +539,33 @@ define(function (require, exports, module) {
         KeyBindingManager.on(KeyBindingManager.EVENT_NEW_PRESET, _updatePresets);
         KeyBindingManager.on(KeyBindingManager.EVENT_PRESET_CHANGED, _updatePresets);
 
+        // Track whether the shortcuts panel has an open tab (survives container collapse).
+        let _shortcutsTabOpen = false;
+
         // When the panel tab is closed externally (e.g. via the × button),
         // update the menu checked state and clean up resources.
         WorkspaceManager.on(WorkspaceManager.EVENT_WORKSPACE_PANEL_HIDDEN, function (event, panelID) {
             if (panelID === TOGGLE_SHORTCUTS_ID && panel) {
+                _shortcutsTabOpen = false;
                 destroyKeyList();
                 _clearSortingEventHandlers();
                 CommandManager.get(TOGGLE_SHORTCUTS_ID).setChecked(false);
             }
+            // Container collapsed — uncheck menu item but keep tab-open flag
+            if (panelID === WorkspaceManager.DEFAULT_PANEL_ID) {
+                CommandManager.get(TOGGLE_SHORTCUTS_ID).setChecked(false);
+            }
+        });
+
+        // When any bottom panel is shown (container is visible),
+        // re-check menu item if shortcuts panel still has an open tab.
+        WorkspaceManager.on(WorkspaceManager.EVENT_WORKSPACE_PANEL_SHOWN, function (event, panelID) {
+            if (panelID === TOGGLE_SHORTCUTS_ID) {
+                _shortcutsTabOpen = true;
+            }
+            if (_shortcutsTabOpen) {
+                CommandManager.get(TOGGLE_SHORTCUTS_ID).setChecked(true);
+            }
         });
     });
 });

src/view/DefaultPanelView.js

@@ -198,12 +198,13 @@ define(function (require, exports, module) {
             }
         });
 
-        // Update drawer button state when panels are shown.
+        // Update drawer button state based on bottom panel container visibility.
+        // The app drawer icon stays selected whenever the bottom panel is visible.
         PanelView.on(PanelView.EVENT_PANEL_SHOWN, function (event, panelID) {
             if (panelID === WorkspaceManager.DEFAULT_PANEL_ID) {
                 _updateButtonVisibility();
             }
-            $drawerBtn.toggleClass("selected-button", panelID === WorkspaceManager.DEFAULT_PANEL_ID);
+            $drawerBtn.addClass("selected-button");
         });
 
         PanelView.on(PanelView.EVENT_PANEL_HIDDEN, function (event, panelID) {

src/view/PanelView.js

@@ -899,8 +899,18 @@ define(function (require, exports, module) {
         // Maximize state is preserved so the panel re-opens maximized.
         _$tabBar.on("click", ".bottom-panel-hide-btn", function (e) {
             e.stopPropagation();
-            if (_$container.is(":visible")) {
+            if (_$container && _$container.is(":visible")) {
+                if (_activeId) {
+                    const activePanel = _panelMap[_activeId];
+                    if (activePanel) {
+                        activePanel.$panel.removeClass("active-bottom-panel");
+                    }
+                }
+                _activeId = null;
+                _updateActiveTabHighlight();
+                restoreIfMaximized();
                 Resizer.hide(_$container[0]);
+                exports.trigger(EVENT_PANEL_HIDDEN, _defaultPanelId);
             }
         });