Conversation
Lets users hide the documentation popup shown beside code hints while keeping the hint list itself enabled.
…Hints pref - new showParameterHints pref (default true) gating the parameter hint popup for implicit and explicit invocation, dismissing a visible popup the moment it flips off - every language server now has a codeIntelligence.<serverId> off-switch: LSPClient gates registerLanguageServer on it and auto-defines the pref for plugin-supplied servers so they get a discoverable toggle for free - runtime toggling handled centrally in LSPClient: pref off stops the server process (fallback linters take over), pref on restarts in place; restartLanguageServer/changeWorkspaceRoot/crash auto-restart guarded so a disabled server can never resurrect - new typescript/json master prefs; php/python prefs renamed to the new codeIntelligence.* family (dev-only, no aliases needed) - pref-off stop no longer logged as a crash (serverExit race with the _stopping flag) - specs: LSPClient gate + auto-define, stop/block-resurrection/restart, showParameterHints gating, json toggle round-trip
Hint-severity (4) LSP diagnostics without tags are refactoring suggestions (e.g. tsserver's "File is a CommonJS module; it may be converted to an ES module") - drop them in the publishDiagnostics path so they never reach the problems panel or the quickfix layer. Tagged hints stay: unused symbols (tag Unnecessary) and deprecated usages (tag Deprecated) keep their panel row and squiggle, and now additionally render faded / struck-through in the editor via new editor-text-fragment-unnecessary/-deprecated mark classes applied from the diagnostic tags. Specs: tagged hints survive with panel rows + text marks; the untagged CommonJS suggestion never comes through (publish-level capture).
|
abose
changed the title
abose
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecated and unused vars
Only works when ts check is enebaled in jsconfig.json in JS files or if writing a ts file.
in PHP
Hint-severity (4) LSP diagnostics without tags are refactoring
suggestions (e.g. tsserver's "File is a CommonJS module; it may be
converted to an ES module") - drop them in the publishDiagnostics path
so they never reach the problems panel or the quickfix layer.
Tagged hints stay: unused symbols (tag Unnecessary) and deprecated
usages (tag Deprecated) keep their panel row and squiggle, and now
additionally render faded / struck-through in the editor via new
editor-text-fragment-unnecessary/-deprecated mark classes applied from
the diagnostic tags.
Specs: tagged hints survive with panel rows + text marks; the untagged
CommonJS suggestion never comes through (publish-level capture).
preferences
popup for implicit and explicit invocation, dismissing a visible popup
the moment it flips off
LSPClient gates registerLanguageServer on it and auto-defines the pref
for plugin-supplied servers so they get a discoverable toggle for free
server process (fallback linters take over), pref on restarts in place;
restartLanguageServer/changeWorkspaceRoot/crash auto-restart guarded so
a disabled server can never resurrect
codeIntelligence.* family (dev-only, no aliases needed)
_stopping flag)
showParameterHints gating, json toggle round-trip
and other changes, see commit description