Fix release workflow: add -O igncr for Cygwin CRLF handling

GitHub Actions writes temp scripts with CRLF on Windows. Without
igncr, Cygwin bash treats \r as part of arguments — the download
step created googletest-src\r instead of googletest-src, causing
the configure step to fail with "source directory does not exist".

Changes:
- Add -O igncr to Cygwin bash shell spec via defaults.run.shell
- Switch multi-command steps from > (folded) to | (literal) blocks
- Add verification (ls, test -d) after GoogleTest download
- Replace Python release notes with shell heredoc
- Use shell: bash for publish step (ensures gh on PATH)

Author: phdye

.github/workflows/release.yml

@@ -11,17 +11,18 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
-env:
-  CYGWIN_SHELL: C:\cygwin\bin\bash.exe --noprofile --norc -eo pipefail '{0}'
-
 jobs:
   release:
     runs-on: windows-latest
     name: Build and publish Cygwin x86_64
     timeout-minutes: 90
+    defaults:
+      run:
+        shell: C:\cygwin\bin\bash.exe --noprofile --norc -O igncr -eo pipefail '{0}'
 
     steps:
       - run: git config --global core.autocrlf input
+        shell: bash
 
       - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
 
@@ -35,38 +36,34 @@ jobs:
             curl
 
       - name: Build environment
-        shell: C:\cygwin\bin\bash.exe --noprofile --norc -eo pipefail '{0}'
-        run: >
-          echo "GCC: $(g++ -dumpfullversion),
-          $(cmake --version | head -1),
-          Cygwin $(uname -r)"
+        run: |
+          echo "GCC: $(g++ -dumpfullversion)"
+          echo "CMake: $(cmake --version | head -1)"
+          echo "Cygwin: $(uname -r)"
+          echo "CWD: $(pwd)"
 
       - name: Download GoogleTest
-        shell: C:\cygwin\bin\bash.exe --noprofile --norc -eo pipefail '{0}'
-        run: >
+        run: |
           curl -fL -o gtest.tar.gz https://github.com/google/googletest/archive/refs/tags/v1.16.0.tar.gz
-          && tar xzf gtest.tar.gz
-          && mv googletest-1.16.0 googletest-src
+          ls -l gtest.tar.gz
+          tar xzf gtest.tar.gz
+          mv googletest-1.16.0 googletest-src
+          test -d googletest-src
 
       - name: Configure GoogleTest
-        shell: C:\cygwin\bin\bash.exe --noprofile --norc -eo pipefail '{0}'
         run: >
           cmake -S googletest-src -B gtest-build -G Ninja
           -DCMAKE_CXX_STANDARD=17
           -DCMAKE_BUILD_TYPE=Release
           -DCMAKE_CXX_FLAGS="-D_GLIBCXX_USE_CXX11_ABI=1"
           -DCMAKE_INSTALL_PREFIX="$PWD/staging/usr/local/lib/absl/vendor"
 
-      - name: Build GoogleTest
-        shell: C:\cygwin\bin\bash.exe --noprofile --norc -eo pipefail '{0}'
-        run: ninja -C gtest-build -j4
-
-      - name: Install GoogleTest
-        shell: C:\cygwin\bin\bash.exe --noprofile --norc -eo pipefail '{0}'
-        run: cmake --install gtest-build
+      - name: Build and install GoogleTest
+        run: |
+          ninja -C gtest-build -j4
+          cmake --install gtest-build
 
       - name: Configure Abseil
-        shell: C:\cygwin\bin\bash.exe --noprofile --norc -eo pipefail '{0}'
         run: >
           cmake -S . -B build -G Ninja
           -DCMAKE_CXX_STANDARD=17
@@ -78,48 +75,38 @@ jobs:
           -DABSL_FIND_GOOGLETEST=ON
 
       - name: Build Abseil
-        shell: C:\cygwin\bin\bash.exe --noprofile --norc -eo pipefail '{0}'
         run: ninja -C build -j4
 
       - name: Test
-        shell: C:\cygwin\bin\bash.exe --noprofile --norc -eo pipefail '{0}'
         run: ctest --test-dir build --timeout 300 --output-on-failure
 
       - name: Install Abseil
-        shell: C:\cygwin\bin\bash.exe --noprofile --norc -eo pipefail '{0}'
         run: cmake --install build --prefix "$PWD/staging/usr/local"
 
       - name: Patch abslConfig.cmake for vendored GoogleTest
-        shell: C:\cygwin\bin\bash.exe --noprofile --norc -eo pipefail '{0}'
-        run: >
-          printf '\n# Vendored GoogleTest for test helper targets (scoped_mock_log, status_matchers)\nif(NOT TARGET GTest::gtest)\n  find_package(GTest QUIET HINTS "${CMAKE_CURRENT_LIST_DIR}/../../absl/vendor/lib/cmake/GTest")\nendif()\n'
-          >> staging/usr/local/lib/cmake/absl/abslConfig.cmake
+        run: |
+          printf '\n# Vendored GoogleTest for test helper targets (scoped_mock_log, status_matchers)\nif(NOT TARGET GTest::gtest)\n  find_package(GTest QUIET HINTS "${CMAKE_CURRENT_LIST_DIR}/../../absl/vendor/lib/cmake/GTest")\nendif()\n' >> staging/usr/local/lib/cmake/absl/abslConfig.cmake
 
       - name: Package
-        shell: C:\cygwin\bin\bash.exe --noprofile --norc -eo pipefail '{0}'
-        run: >
-          tar czf "abseil-cpp-$GITHUB_REF_NAME-x86_64.tar.gz" -C staging usr
+        run: tar czf "abseil-cpp-$GITHUB_REF_NAME-x86_64.tar.gz" -C staging usr
 
       - name: Checksum
-        shell: C:\cygwin\bin\bash.exe --noprofile --norc -eo pipefail '{0}'
-        run: >
+        run: |
           sha256sum "abseil-cpp-$GITHUB_REF_NAME-x86_64.tar.gz" > checksums-sha256.txt
-          && cat checksums-sha256.txt
+          cat checksums-sha256.txt
 
       - name: Create release notes
-        shell: C:\cygwin\bin\bash.exe --noprofile --norc -eo pipefail '{0}'
-        run: >
-          python3 -c "
-          import subprocess, os;
-          tag = os.environ['GITHUB_REF_NAME'];
-          ver = tag.replace('-cygwin', '');
-          artifact = f'abseil-cpp-{tag}-x86_64.tar.gz';
-          gcc = subprocess.check_output(['g++', '-dumpfullversion']).decode().strip();
-          cmake = subprocess.check_output(['cmake', '--version']).decode().split('\n')[0];
-          cygwin = subprocess.check_output(['uname', '-r']).decode().strip();
-          body = f'''Pre-built static libraries and headers for Cygwin x86_64.
-
-          **Build environment**: GCC {gcc}, {cmake}, Cygwin {cygwin}, Release mode
+        run: |
+          tag="$GITHUB_REF_NAME"
+          ver="${tag%-cygwin}"
+          artifact="abseil-cpp-${tag}-x86_64.tar.gz"
+          gcc="$(g++ -dumpfullversion)"
+          cmake_ver="$(cmake --version | head -1)"
+          cygwin_ver="$(uname -r)"
+          cat > release-notes.md <<EOF
+          Pre-built static libraries and headers for Cygwin x86_64.
+
+          **Build environment**: GCC ${gcc}, ${cmake_ver}, Cygwin ${cygwin_ver}, Release mode
           **ABI**: \`-D_GLIBCXX_USE_CXX11_ABI=1\` (SSO strings, required for Protobuf compatibility)
           **Prefix**: \`/usr/local\` (does not conflict with system abseil in \`/usr\`)
           **GoogleTest**: 1.16.0, vendored at \`lib/absl/vendor/\`
@@ -129,7 +116,7 @@ jobs:
           Extract at the filesystem root to install into \`/usr/local\`:
 
           \`\`\`bash
-          cd / && tar xzf {artifact}
+          cd / && tar xzf ${artifact}
           \`\`\`
 
           Verify checksum:
@@ -159,16 +146,14 @@ jobs:
 
           These binaries support the Cygwin port of Protocol Buffers 7.35.0 at
           [phdye-cygwin/protobuf](https://github.com/phdye-cygwin/protobuf).
-          ''';
-          open('release-notes.md', 'w').write(body)
-          "
+          EOF
 
       - name: Publish release
+        shell: bash
         env:
           GH_TOKEN: ${{ github.token }}
-        shell: C:\cygwin\bin\bash.exe --noprofile --norc -eo pipefail '{0}'
-        run: >
-          gh release create "$GITHUB_REF_NAME"
-          --title "Abseil LTS ${GITHUB_REF_NAME%-cygwin} — Cygwin x86_64"
-          --notes-file release-notes.md
-          "abseil-cpp-$GITHUB_REF_NAME-x86_64.tar.gz" checksums-sha256.txt
+        run: |
+          gh release create "$GITHUB_REF_NAME" \
+            --title "Abseil LTS ${GITHUB_REF_NAME%-cygwin} — Cygwin x86_64" \
+            --notes-file release-notes.md \
+            "abseil-cpp-$GITHUB_REF_NAME-x86_64.tar.gz" checksums-sha256.txt