Skip to content

Allow parent of dropdown be a real link#1155

Open
auipga wants to merge 1 commit into
phiamo:masterfrom
auipga:patch-1
Open

Allow parent of dropdown be a real link#1155
auipga wants to merge 1 commit into
phiamo:masterfrom
auipga:patch-1

Conversation

@auipga

@auipga auipga commented Feb 8, 2016

Copy link
Copy Markdown
Contributor

When changing the behaviour of the menu (eg. open on hover), it should be allowed for the parent of a dropdown to have a URI instead of forcing to href="#"

Example: (--> About)
http://vadikom.github.io/smartmenus/src/demo/index.html

When changing the behaviour of the menu (eg. open on hover), it should be allowed for the parent of a dropdown to have a URI instead of forcing to `href="#"`

Example: (--> About)
http://vadikom.github.io/smartmenus/src/demo/index.html
@phiamo

phiamo commented Feb 3, 2017

Copy link
Copy Markdown
Owner

@auipga how does this behave if you dont set an uri ?

@auipga

auipga commented Mar 7, 2017

Copy link
Copy Markdown
Contributor Author

@phiamo if no URI is set, it uses the original # as fallback

#1035 is not connected with my issue but should also be applied (uri = javascript:;) as this change is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants