Skip to content

Commit d90f10a

Browse files
committed
chore: fix acceptance tests on default branch
1 parent 93b6593 commit d90f10a

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

.github/workflows/wc-acceptance-test.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,11 @@ jobs:
3030
- name: Start Codespace
3131
run: |
3232
set -Eeuo pipefail
33-
gh secret set -a codespaces IMAGE_VERSION --body "pr-${{ github.event.pull_request.number }}"
33+
if [[ "${{ github.event_name }}" == "pull_request" ]]; then
34+
gh secret set -a codespaces IMAGE_VERSION --body "pr-${{ github.event.pull_request.number }}"
35+
else
36+
gh secret set -a codespaces IMAGE_VERSION --body "edge"
37+
fi
3438
echo CODESPACE_NAME="$(gh codespace create -R "${{ github.repository }}" -b "$HEAD_REF" -m basicLinux32gb --devcontainer-path ".devcontainer/${{ inputs.flavor }}-test/devcontainer.json" --idle-timeout 10m --retention-period 1h)" >> "$GITHUB_ENV"
3539
env:
3640
GH_TOKEN: ${{ secrets.TEST_GITHUB_TOKEN }}

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ The amp-devcontainer repository follows a [semantic versioning](https://semver.o
8888

8989
Released containers will never be cleaned-up, pull request builds are cleaned up when the pull request is merged, and edge builds may be cleaned up after being stale for a while.
9090

91-
The release notes always contain an overview of the corresponding image versions that included the full SHA next to the version number. This makes it possible for humans to easily see what version is used while still pinning to an exact version. This is the recommended way to refer to an image.
91+
The release notes always contain an overview of the corresponding image versions that include the full SHA next to the version number. This makes it possible for humans to easily see what version is used while still pinning to an exact version. This is the recommended way to refer to an image.
9292

9393
All container images are included in a release. This might change in the future when the need arises to have separate releases per container.
9494

0 commit comments

Comments
 (0)