fix: expose enable-edge-tag on reusable workflow#1098
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the Docker image tagging logic to provide more explicit control over when the "edge" tag is built and pushed. Instead of relying on event-based conditions directly in the tagging configuration, the workflow now uses a dedicated enable-edge-tag input parameter that is passed through the workflow chain, improving maintainability and clarity.
Changes:
- Added
enable-edge-taginput parameter to reusable workflowswc-build-push.ymlandwc-build-push-test.yml - Updated
continuous-integration.ymlto passenable-edge-tagbased onmerge_groupevent to downstream workflows - Simplified Docker tagging logic to use the new input parameter instead of direct event checking
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/wc-build-push.yml |
Added enable-edge-tag input and updated tagging logic to use it instead of checking event name directly |
.github/workflows/wc-build-push-test.yml |
Added optional enable-edge-tag input with default value of false |
.github/workflows/continuous-integration.yml |
Updated both base and flavor build jobs to pass enable-edge-tag parameter based on merge_group event |
Contributor
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 20 | 0 | 0 | 0.55s | |
| ✅ DOCKERFILE | hadolint | 3 | 0 | 0 | 0.76s | |
| ✅ GHERKIN | gherkin-lint | 6 | 0 | 0 | 2.4s | |
| ✅ JSON | npm-package-json-lint | yes | no | no | 0.47s | |
| ✅ JSON | prettier | 21 | 4 | 0 | 0 | 0.56s |
| ✅ JSON | v8r | 21 | 0 | 0 | 7.78s | |
| ✅ MARKDOWN | markdownlint | 11 | 0 | 0 | 0 | 0.9s |
| ✅ MARKDOWN | markdown-table-formatter | 11 | 0 | 0 | 0 | 0.21s |
| ✅ REPOSITORY | checkov | yes | no | no | 18.05s | |
| ✅ REPOSITORY | gitleaks | yes | no | no | 0.52s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.01s | |
| ✅ REPOSITORY | grype | yes | no | no | 28.82s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 0.96s | |
| ✅ REPOSITORY | syft | yes | no | no | 2.0s | |
| ✅ REPOSITORY | trivy | yes | no | no | 5.44s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.24s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 2.26s | |
| lychee | 79 | 4 | 0 | 33.68s | ||
| ✅ YAML | prettier | 28 | 0 | 0 | 0 | 0.89s |
| ✅ YAML | v8r | 28 | 0 | 0 | 8.6s | |
| ✅ YAML | yamllint | 28 | 0 | 0 | 0.61s |
Detailed Issues
⚠️ SPELL / lychee - 4 errors
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Network error: error sending request for url (https://www.conventionalcommits.org/en/v1.0.0/)
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Error (cached)
[IGNORED] docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a | Unsupported: Error creating request client: builder error for url (docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a)
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Error (cached)
[IGNORED] https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer | Unsupported: Error creating request client: builder error for url (vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer)
📝 Summary
---------------------
🔍 Total..........127
✅ Successful.....121
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........4
Errors in .github/CONTRIBUTING.md
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Network error: error sending request for url (https://www.conventionalcommits.org/en/v1.0.0/)
Errors in .github/workflows/issue-creation-tool-versions.yml
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden
Errors in .github/workflows/pr-conventional-title.yml
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Error (cached)
Errors in README.md
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Error (cached)
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@9.3.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R
André Jordan (andjordan)
approved these changes
Jan 22, 2026
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
|
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
Contributor
Pull Request Report (#1098)Static measures
Time related measures
Status check related measures
|
Contributor
|
🎉 Hooray! The changes in this pull request went live with the release of v6.7.1 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Hey, I have created a Pull Request
Description of changes
This pull request updates the CI workflow configuration to improve Docker image tagging logic, specifically introducing a new
enable-edge-tagparameter that allows more flexible control over when the "edge" Docker tag is built and pushed. The main changes involve propagating this parameter through various workflow files and updating the tagging logic to use the new input.Workflow parameter additions and propagation:
Added a new boolean input parameter
enable-edge-tagto bothwc-build-push.ymlandwc-build-push-test.ymlworkflows, allowing conditional building and pushing of the "edge" Docker tag. [1] [2]Updated jobs in
continuous-integration.ymlto passenable-edge-tag, set based on whether the workflow was triggered by amerge_groupevent, to downstream build jobs. [1] [2]Docker image tagging logic update:
wc-build-push.ymlto use the newenable-edge-taginput, replacing the previous direct event-based condition, for more explicit and flexible control.✔️ Checklist