Skip to content

fix: add required permission to release workflow#1163

Merged
Ron (rjaegers) merged 2 commits into
mainfrom
ci/fix-release-workflow
Feb 24, 2026
Merged

fix: add required permission to release workflow#1163
Ron (rjaegers) merged 2 commits into
mainfrom
ci/fix-release-workflow

Conversation

@rjaegers
Copy link
Copy Markdown
Member

🚀 Hey, I have created a Pull Request

Description of changes

This pull request introduces a small but important update to the GitHub Actions workflow permissions. The change grants the workflow permission to write artifact metadata, which is required for build provenance attestation.

  • Updated .github/workflows/release-build.yml to add artifact-metadata: write permission, enabling actions/attest-build-provenance to write artifact metadata.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

Copilot AI review requested due to automatic review settings February 23, 2026 18:36
@rjaegers Ron (rjaegers) requested a review from a team as a code owner February 23, 2026 18:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the artifact-metadata: write permission to the release workflow to enable build provenance attestation. The permission is required by the actions/attest-build-provenance action that runs in the called reusable workflow.

Changes:

  • Added artifact-metadata: write permission with explanatory comment to the build-push-base job in the release workflow

Comment thread .github/workflows/release-build.yml
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 21 0 0 0.45s
✅ DOCKERFILE hadolint 3 0 0 0.65s
✅ GHERKIN gherkin-lint 6 0 0 2.15s
✅ JSON npm-package-json-lint yes no no 0.33s
✅ JSON prettier 21 4 0 0 0.39s
✅ JSON v8r 21 0 0 7.04s
✅ MARKDOWN markdownlint 12 0 0 0 0.83s
✅ MARKDOWN markdown-table-formatter 12 0 0 0 0.19s
✅ REPOSITORY checkov yes no no 15.8s
✅ REPOSITORY gitleaks yes no no 0.46s
✅ REPOSITORY git_diff yes no no 0.01s
✅ REPOSITORY grype yes no no 36.1s
✅ REPOSITORY secretlint yes no no 0.85s
✅ REPOSITORY syft yes no no 1.83s
✅ REPOSITORY trivy yes no no 7.01s
✅ REPOSITORY trivy-sbom yes no no 0.2s
✅ REPOSITORY trufflehog yes no no 2.3s
⚠️ SPELL lychee 81 5 0 12.07s
✅ YAML prettier 29 0 0 0 0.83s
✅ YAML v8r 29 0 0 7.53s
✅ YAML yamllint 29 0 0 0.79s

Detailed Issues

⚠️ SPELL / lychee - 5 errors
[IGNORED] docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a | Unsupported: Error creating request client: builder error for url (docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a)
[ERROR] https://www.contributor-covenant.org/ | Network error: error sending request for url (https://www.contributor-covenant.org/) Maybe a certificate error?
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Network error: error sending request for url (https://www.conventionalcommits.org/en/v1.0.0/) Maybe a certificate error?
[ERROR] https://slsa.dev/spec/v1.0/threats | Network error: error sending request for url (https://slsa.dev/spec/v1.0/threats)
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Network error: error sending request for url (https://www.conventionalcommits.org/en/v1.0.0/) Maybe a certificate error?
[IGNORED] https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer | Unsupported: Error creating request client: builder error for url (vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer)
📝 Summary
---------------------
🔍 Total..........126
✅ Successful.....119
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........5

Errors in .github/TOOL_VERSION_ISSUE_TEMPLATE.md
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden

Errors in test/cpp/features/security.feature
[ERROR] https://slsa.dev/spec/v1.0/threats | Network error: error sending request for url (https://slsa.dev/spec/v1.0/threats)

Errors in README.md
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Network error: error sending request for url (https://www.conventionalcommits.org/en/v1.0.0/) Maybe a certificate error?

Errors in .github/CODE_OF_CONDUCT.md
[ERROR] https://www.contributor-covenant.org/ | Network error: error sending request for url (https://www.contributor-covenant.org/) Maybe a certificate error?

Errors in .github/CONTRIBUTING.md
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Network error: error sending request for url (https://www.conventionalcommits.org/en/v1.0.0/) Maybe a certificate error?

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.3.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-base:edgeghcr.io/philips-software/amp-devcontainer-base:pr-1163

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 175.16 MB 175.16 MB +113 B (+0%) 🔼
linux/arm64 167.63 MB 167.63 MB 49 B (0%) 🔽

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edgeghcr.io/philips-software/amp-devcontainer-rust:pr-1163

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 555.57 MB 555.57 MB +170 B (+0%) 🔼
linux/arm64 509.75 MB 509.75 MB +108 B (+0%) 🔼

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edgeghcr.io/philips-software/amp-devcontainer-cpp:pr-1163

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 696.88 MB 696.88 MB 601 B (0%) 🔽
linux/arm64 677.68 MB 677.68 MB 179 B (0%) 🔽

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

Test Results

 7 files  ±0   7 suites  ±0   4m 7s ⏱️ ±0s
33 tests ±0  33 ✅ ±0  0 💤 ±0  0 ❌ ±0 
69 runs  ±0  69 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7a0f6e7. ± Comparison against base commit 78e6999.

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link
Copy Markdown

@rjaegers Ron (rjaegers) changed the title ci: fix release workflow fix: add required permission to release workflow Feb 24, 2026
@rjaegers Ron (rjaegers) added this pull request to the merge queue Feb 24, 2026
Merged via the queue into main with commit 6041313 Feb 24, 2026
50 checks passed
@rjaegers Ron (rjaegers) deleted the ci/fix-release-workflow branch February 24, 2026 09:01
@github-actions
Copy link
Copy Markdown
Contributor

Pull Request Report (#1163)

Static measures

Description Value
Number of added lines 2
Number of deleted lines 0
Number of changed files 1
Number of commits 2
Number of reviews 4
Number of comments (w/o review comments) 6
Number of reviews that contains a comment to resolve 2
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 2
Get the total number of participants of a Pull Request 7

Time related measures

Description Value
PR lead time (from creation to close of PR) 14.4 Hours
Time that was spend on the branch before the PR was created 32 Sec
Time that was spend on the branch before the PR was merged 14.4 Hours
Time to merge after last review 29.5 Min

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 57 Min
Total time spend in last status check run on PR 12.5 Hours

@github-actions
Copy link
Copy Markdown
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v6.8.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants