Skip to content

feat: update clang to 21.1.8#1294

Merged
Ron (rjaegers) merged 1 commit into
mainfrom
feature/update-clang-to-21
Jun 2, 2026
Merged

feat: update clang to 21.1.8#1294
Ron (rjaegers) merged 1 commit into
mainfrom
feature/update-clang-to-21

Conversation

@rjaegers
Copy link
Copy Markdown
Member

🚀 Hey, I have created a Pull Request

Description of changes

This pull request updates the C++ development container to use Clang version 21 and the latest version of Include-What-You-Use, ensuring the environment is up to date with the latest compiler and tooling versions.

Development environment updates:

  • Updated the base Clang version used in the development container from 20 to 21 in both the .devcontainer/cpp/Dockerfile and the apt-requirements-clang.json package list, including all related tools and libraries (clang, clangd, clang-format, clang-tidy, clang-tools, libclang-rt, lld, llvm, and mull). [1] [2]
  • Bumped the INCLUDE_WHAT_YOU_USE_VERSION from 0.24 to 0.25 in the Dockerfile to use the latest version of this tool.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

Copilot AI review requested due to automatic review settings June 2, 2026 06:32
@rjaegers Ron (rjaegers) requested a review from a team as a code owner June 2, 2026 06:32
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 2, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 23 0 0 0.21s
✅ DOCKERFILE hadolint 3 0 0 0.3s
✅ JSON npm-package-json-lint yes no no 0.58s
✅ JSON prettier 21 4 0 0 0.71s
✅ JSON v8r 21 0 0 12.08s
✅ MARKDOWN markdownlint 12 0 0 0 1.08s
✅ MARKDOWN markdown-table-formatter 12 0 0 0 0.26s
✅ REPOSITORY checkov yes no no 25.18s
✅ REPOSITORY gitleaks yes no no 1.06s
✅ REPOSITORY git_diff yes no no 0.01s
✅ REPOSITORY grype yes no no 58.41s
✅ REPOSITORY secretlint yes no no 2.01s
✅ REPOSITORY syft yes no no 2.13s
✅ REPOSITORY trivy yes no no 13.46s
✅ REPOSITORY trivy-sbom yes no no 0.44s
✅ REPOSITORY trufflehog yes no no 7.09s
⚠️ SPELL lychee 83 1 0 21.52s
✅ YAML prettier 31 0 0 0 1.1s
✅ YAML v8r 31 0 0 11.93s
✅ YAML yamllint 31 0 0 1.36s

Detailed Issues

⚠️ SPELL / lychee - 1 error
[IGNORED] docker://pandoc/extra:3.9.0.0-ubuntu@sha256:72afa9c8d3300e5f10c9c4330e101725687f2179bffd912fb859c6d2ae85de62 | Unsupported: Error creating request client: builder error for url (docker://pandoc/extra:3.9.0.0-ubuntu@sha256:72afa9c8d3300e5f10c9c4330e101725687f2179bffd912fb859c6d2ae85de62)
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden
[IGNORED] https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer | Unsupported: Error creating request client: builder error for url (vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer)
📝 Summary
---------------------
🔍 Total..........126
✅ Successful.....123
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........1

Errors in .github/TOOL_VERSION_ISSUE_TEMPLATE.md
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden

See detailed reports in MegaLinter artifacts

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.4.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-base:edgeghcr.io/philips-software/amp-devcontainer-base:pr-1294

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 71.82 MB 71.82 MB +78 B (+0%) 🔼
linux/arm64 70.12 MB 70.12 MB 6 B (0%) 🔽

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the C++ devcontainer toolchain to Clang/LLVM 21.1.8 (and related tooling) to keep the container aligned with the latest supported compiler stack on the current Ubuntu base.

Changes:

  • Bump the C++ container’s CLANG_VERSION default from 20 → 21.
  • Update pinned APT package set for the Clang toolchain from *-20 to *-21 at version 21.1.8-6ubuntu1.
  • Bump Include-What-You-Use from 0.240.25.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.devcontainer/cpp/Dockerfile Sets default tool versions to Clang 21 and IWYU 0.25 for the C++ flavor image build.
.devcontainer/cpp/apt-requirements-clang.json Updates the pinned Clang/LLVM-related APT package names and versions to the 21.1.8 release line.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edgeghcr.io/philips-software/amp-devcontainer-rust:pr-1294

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 468.63 MB 468.63 MB +322 B (+0%) 🔼
linux/arm64 419.81 MB 419.81 MB +386 B (+0%) 🔼

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edgeghcr.io/philips-software/amp-devcontainer-cpp:pr-1294

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 547.82 MB 547.98 MB +163.45 kB (+0.03%) 🔼
linux/arm64 527.01 MB 527.51 MB +497.44 kB (+0.09%) 🔼

@rjaegers Ron (rjaegers) temporarily deployed to acceptance-testing June 2, 2026 06:44 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Test Results

 13 files  ±0   13 suites  ±0   18m 13s ⏱️ +37s
 33 tests ±0   33 ✅ ±0  0 💤 ±0  0 ❌ ±0 
137 runs  ±0  137 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a827060. ± Comparison against base commit 174da34.

@rjaegers Ron (rjaegers) added this pull request to the merge queue Jun 2, 2026
Merged via the queue into main with commit 2580f8e Jun 2, 2026
56 checks passed
@rjaegers Ron (rjaegers) deleted the feature/update-clang-to-21 branch June 2, 2026 07:22
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Pull Request Report (#1294)

Static measures

Description Value
Number of added lines 11
Number of deleted lines 11
Number of changed files 2
Number of commits 1
Number of reviews 2
Number of comments (w/o review comments) 6
Number of reviews that contains a comment to resolve 1
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 5

Time related measures

Description Value
PR lead time (from creation to close of PR) 49.7 Min
Time that was spend on the branch before the PR was created 28 Sec
Time that was spend on the branch before the PR was merged 50.1 Min
Time to merge after last review 38.4 Min

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 1.2 Hours
Total time spend in last status check run on PR 50 Min

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

🎉 Hooray! The changes in this pull request went live with the release of v7.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants