ci: fix automated release notes update#791
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the automated release notes update by ensuring that a cloned repository with the .git folder is available for the GitHub CLI in the release-please workflow.
- Added an actions/checkout step with persist-credentials set to false
- Ensured the GitHub CLI workflow runs correctly in the release process
Comments suppressed due to low confidence (1)
.github/workflows/release-please.yml:19
- [nitpick] Consider referencing the action version using the published tag (e.g., actions/checkout@v4) rather than a commit hash for improved clarity and maintainability.
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Compressed layer size comparisonComparing
|
Compressed layer size comparisonComparing
|
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:
|
Test Results 2 files 2 suites 1m 18s ⏱️ Results for commit 2612639. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with automated release notes updates by ensuring the repository is properly cloned for the GitHub CLI to work, and refactors the build-push workflow to format the digest string correctly for file naming.
- Introduces a checkout step in the release-please workflow
- Reformats the digest string in the build-push workflow for valid shell parameter expansion
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/release-please.yml | Adds an actions/checkout step to ensure the .git directory is available. |
| .github/workflows/build-push.yml | Modifies the way the digest string is formatted for file naming in the attestation verification step. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ron <45816308+rjaegers@users.noreply.github.com>
Signed-off-by: Ron <45816308+rjaegers@users.noreply.github.com>
The GitHub Pull Request extension has been renamed in the UI to just GitHub and shows PR and Issue data
The latest version 17 manifest has a Clang-19 check, and amp-devcontainer-cpp is not yet on Clang-19
|
Pull Request Report (#791)Static measures
Time related measures
Status check related measures
|
|
🎉 Hooray! The changes in this pull request went live with the release of v6.0.2 🎉 |




🚀 Hey, I have created a Pull Request
Description of changes
Using the GitHub cli (gh) needs a cloned repository (.git folder), in the release-please workflow it is thus necessary to use the actions/checkout step.
✔️ Checklist