Skip to content

ci: fix automated release notes update#791

Merged
Ron (rjaegers) merged 6 commits into
mainfrom
feature/fix-automated-release-notes-update
May 19, 2025
Merged

ci: fix automated release notes update#791
Ron (rjaegers) merged 6 commits into
mainfrom
feature/fix-automated-release-notes-update

Conversation

@rjaegers
Copy link
Copy Markdown
Member

🚀 Hey, I have created a Pull Request

Description of changes

Using the GitHub cli (gh) needs a cloned repository (.git folder), in the release-please workflow it is thus necessary to use the actions/checkout step.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

Copilot AI review requested due to automatic review settings May 7, 2025 06:20
@rjaegers Ron (rjaegers) requested a review from a team as a code owner May 7, 2025 06:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the automated release notes update by ensuring that a cloned repository with the .git folder is available for the GitHub CLI in the release-please workflow.

  • Added an actions/checkout step with persist-credentials set to false
  • Ensured the GitHub CLI workflow runs correctly in the release process
Comments suppressed due to low confidence (1)

.github/workflows/release-please.yml:19

  • [nitpick] Consider referencing the action version using the published tag (e.g., actions/checkout@v4) rather than a commit hash for improved clarity and maintainability.
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2025

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:7ae06eeae67ceda6e71b3ab222d95855d4e5bb006fb2f99e9d5c79e3bf3e1dc9

OS/Platform Previous Size Current Size Delta
linux/amd64 482.86M 482.86M 0.00 (+0.00%)
linux/arm64 434.30M 434.30M 0.00 (+0.00%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2025

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:22bc8c2f7fccb1672b61797bbcc19f3ccafe36e6dfe942b04b30b22ccfb158bb

OS/Platform Previous Size Current Size Delta
linux/amd64 692.87M 693.68M 835.90K (+0.12%)
linux/arm64 674.96M 675.77M 828.64K (+0.12%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ DOCKERFILE hadolint 2 0 0 0.64s
✅ GHERKIN gherkin-lint 2 0 0 1.03s
✅ JSON npm-package-json-lint yes no no 0.35s
✅ JSON prettier 15 1 0 0 0.42s
✅ JSON v8r 15 0 0 7.94s
✅ MARKDOWN markdownlint 9 0 0 0 0.77s
✅ MARKDOWN markdown-table-formatter 9 0 0 0 0.19s
✅ REPOSITORY checkov yes no no 15.18s
✅ REPOSITORY gitleaks yes no no 0.27s
✅ REPOSITORY git_diff yes no no 0.01s
✅ REPOSITORY grype yes no no 21.29s
✅ REPOSITORY secretlint yes no no 0.91s
✅ REPOSITORY syft yes no no 1.09s
✅ REPOSITORY trivy yes no no 6.92s
✅ REPOSITORY trivy-sbom yes no no 0.09s
✅ REPOSITORY trufflehog yes no no 3.56s
✅ SPELL lychee 60 0 0 11.51s
✅ YAML prettier 22 0 0 0 0.63s
✅ YAML v8r 22 0 0 6.29s
✅ YAML yamllint 22 0 0 0.51s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2025

Test Results

 2 files   2 suites   1m 18s ⏱️
29 tests 29 ✅ 0 💤 0 ❌
31 runs  31 ✅ 0 💤 0 ❌

Results for commit 2612639.

♻️ This comment has been updated with latest results.

@rjaegers Ron (rjaegers) requested a review from Copilot May 7, 2025 06:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with automated release notes updates by ensuring the repository is properly cloned for the GitHub CLI to work, and refactors the build-push workflow to format the digest string correctly for file naming.

  • Introduces a checkout step in the release-please workflow
  • Reformats the digest string in the build-push workflow for valid shell parameter expansion

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/release-please.yml Adds an actions/checkout step to ensure the .git directory is available.
.github/workflows/build-push.yml Modifies the way the digest string is formatted for file naming in the attestation verification step.

Comment thread .github/workflows/build-push.yml Outdated
Ron (rjaegers) and others added 2 commits May 7, 2025 08:53
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Ron <45816308+rjaegers@users.noreply.github.com>
Signed-off-by: Ron <45816308+rjaegers@users.noreply.github.com>
@rjaegers Ron (rjaegers) added this pull request to the merge queue May 16, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 16, 2025
The GitHub Pull Request extension has been renamed in the UI to just GitHub and shows PR and Issue data
The latest version 17 manifest has a Clang-19 check, and amp-devcontainer-cpp is not yet on Clang-19
@sonarqubecloud
Copy link
Copy Markdown

@rjaegers Ron (rjaegers) added this pull request to the merge queue May 19, 2025
Merged via the queue into main with commit 37222b8 May 19, 2025
22 checks passed
@rjaegers Ron (rjaegers) deleted the feature/fix-automated-release-notes-update branch May 19, 2025 06:56
@github-actions
Copy link
Copy Markdown
Contributor

Pull Request Report (#791)

Static measures

Description Value
Number of added lines 9
Number of deleted lines 4
Number of changed files 4
Number of commits 6
Number of reviews 3
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 2
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 6

Time related measures

Description Value
PR lead time (from creation to close of PR) 12 Days
Time that was spend on the branch before the PR was created 2 Min
Time that was spend on the branch before the PR was merged 12 Days
Time to merge after last review 3 Days

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 25.4 Min
Total time spend in last status check run on PR 10.9 Min

@github-actions
Copy link
Copy Markdown
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v6.0.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants