feat(codereview): add issue cache with refresh and age display #463

Implement persistent caching for issue info with timestamps, cache age indicators in UI, and manual refresh support to reduce API calls and improve transparency.

Author: phodal

mpp-core/src/commonMain/kotlin/cc/unitmesh/agent/tracker/IssueTracker.kt

@@ -1,5 +1,8 @@
 package cc.unitmesh.agent.tracker
 
+import kotlinx.datetime.Clock
+import kotlinx.datetime.Instant
+
 /**
  * Issue information from issue tracker
  */
@@ -12,8 +15,46 @@ data class IssueInfo(
     val author: String? = null,
     val assignees: List<String> = emptyList(),
     val createdAt: String? = null,
-    val updatedAt: String? = null
-)
+    val updatedAt: String? = null,
+    /**
+     * When this issue info was fetched/cached (null if freshly fetched)
+     */
+    val cachedAt: Instant? = null
+) {
+    /**
+     * Check if this issue info is from cache
+     */
+    val isFromCache: Boolean get() = cachedAt != null
+    
+    /**
+     * Get cache age in minutes (null if not cached)
+     */
+    fun getCacheAgeMinutes(): Long? {
+        return cachedAt?.let {
+            (Clock.System.now() - it).inWholeMinutes
+        }
+    }
+    
+    /**
+     * Get human-readable cache age
+     */
+    fun getCacheAgeDisplay(): String? {
+        val minutes = getCacheAgeMinutes() ?: return null
+        return when {
+            minutes < 1 -> "just now"
+            minutes < 60 -> "${minutes}m ago"
+            minutes < 1440 -> "${minutes / 60}h ago"
+            else -> "${minutes / 1440}d ago"
+        }
+    }
+    
+    /**
+     * Create a cached copy with current timestamp
+     */
+    fun withCacheTimestamp(timestamp: Instant = Clock.System.now()): IssueInfo {
+        return copy(cachedAt = timestamp)
+    }
+}
 
 /**
  * Abstract interface for issue tracking systems

mpp-ui/src/commonMain/kotlin/cc/unitmesh/devins/ui/compose/agent/codereview/CodeReviewModels.kt

@@ -135,5 +135,7 @@ data class CommitInfo(
     val message: String,
     val issueInfo: IssueInfo? = null, // Issue information extracted from commit message
     val isLoadingIssue: Boolean = false, // Whether issue info is being loaded
-    val issueLoadError: String? = null // Error message if issue loading failed (e.g., needs token)
+    val issueLoadError: String? = null, // Error message if issue loading failed (e.g., needs token)
+    val issueFromCache: Boolean = false, // Whether issue info was loaded from cache
+    val issueCacheAge: String? = null // Human-readable cache age (e.g., "5m ago")
 )

mpp-ui/src/commonMain/kotlin/cc/unitmesh/devins/ui/compose/agent/codereview/CodeReviewSideBySideView.kt

@@ -158,6 +158,15 @@ private fun ThreeColumnLayout(
                     val workspaceRoot = viewModel.workspace.rootPath
                     val onConfigureToken = onShowConfigDialog
 
+                    // Map selected commit indices for refresh callback
+                    val selectedIndicesList = state.selectedCommitIndices.toList().sorted()
+                    val onRefreshIssue: (Int) -> Unit = { relativeIndex ->
+                        // Map relative index in selectedCommits to actual commitHistory index
+                        selectedIndicesList.getOrNull(relativeIndex)?.let { actualIndex ->
+                            viewModel.refreshIssueForCommit(actualIndex)
+                        }
+                    }
+                    
                     DiffCenterView(
                         diffFiles = state.diffFiles,
                         selectedCommits = state.selectedCommitIndices.mapNotNull { state.commitHistory.getOrNull(it) },
@@ -166,6 +175,7 @@ private fun ThreeColumnLayout(
                         workspaceRoot = workspaceRoot,
                         isLoadingDiff = state.isLoadingDiff,
                         onConfigureToken = onConfigureToken,
+                        onRefreshIssue = onRefreshIssue,
                         relatedTests = state.relatedTests,
                         isLoadingTests = state.isLoadingTests
                     )

mpp-ui/src/commonMain/kotlin/cc/unitmesh/devins/ui/compose/agent/codereview/CodeReviewViewModel.kt

@@ -1081,12 +1081,13 @@ open class CodeReviewViewModel(
      * Load issue information for a specific commit asynchronously
      *
      * @param commitIndex Index of the commit in commitHistory
+     * @param forceRefresh If true, bypass cache and fetch fresh data
      */
-    private fun loadIssueForCommit(commitIndex: Int) {
+    private fun loadIssueForCommit(commitIndex: Int, forceRefresh: Boolean = false) {
         val commit = currentState.commitHistory.getOrNull(commitIndex) ?: return
 
-        // Skip if already loaded or loading
-        if (commit.issueInfo != null || commit.isLoadingIssue) {
+        // Skip if already loaded or loading (unless force refresh)
+        if (!forceRefresh && (commit.issueInfo != null || commit.isLoadingIssue)) {
             return
         }
 
@@ -1096,17 +1097,25 @@ open class CodeReviewViewModel(
         // Load issue asynchronously
         scope.launch {
             try {
-                val issueDeferred = issueService.getIssueAsync(commit.hash, commit.message)
+                val issueDeferred = issueService.getIssueAsync(commit.hash, commit.message, forceRefresh)
                 val result = issueDeferred.await()
 
                 // Update commit with issue info or error
                 updateCommitAtIndex(commitIndex) {
                     it.copy(
                         issueInfo = result.issueInfo,
                         isLoadingIssue = false,
-                        issueLoadError = result.error
+                        issueLoadError = result.error,
+                        issueFromCache = result.fromCache,
+                        issueCacheAge = result.cacheAgeDisplay
                     )
                 }
+                
+                if (result.fromCache) {
+                    AutoDevLogger.debug("CodeReviewViewModel") {
+                        "Loaded cached issue for commit ${commit.shortHash} (cached ${result.cacheAgeDisplay})"
+                    }
+                }
             } catch (e: Exception) {
                 AutoDevLogger.error("CodeReviewViewModel") {
                     "Failed to load issue for commit ${commit.shortHash}: ${e.message}"
@@ -1120,6 +1129,13 @@ open class CodeReviewViewModel(
             }
         }
     }
+    
+    /**
+     * Force refresh issue for a specific commit (bypasses cache)
+     */
+    fun refreshIssueForCommit(commitIndex: Int) {
+        loadIssueForCommit(commitIndex, forceRefresh = true)
+    }
 
     /**
      * Update a commit at a specific index