Skip to content

Declare JavaScript v2 content modules for 2026.2 platform compatibility #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Declare JavaScript v2 content modules for 2026.2 platform compatibility #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa178c1
Initial plan
Copilot May 13, 2026
3c5b137
fix: declare JavaScript v2 module dependencies
Copilot May 13, 2026
c385b37
test: improve JavaScript descriptor assertions
Copilot May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mpp-idea/mpp-idea-lang/javascript/src/main/resources/cc.unitmesh.javascript.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
<idea-plugin package="cc.unitmesh.ide.javascript">
<!--suppress PluginXmlValidity -->
<dependencies>
<module name="intellij.javascript.backend"/>
<module name="intellij.javascript.common"/>
<module name="intellij.javascript.psi.impl"/>
<module name="intellij.javascript.testing"/>
<plugin id="JavaScript"/>
</dependencies>

Expand Down
40 changes: 40 additions & 0 deletions ...g/javascript/src/test/kotlin/cc/unitmesh/ide/javascript/JavaScriptPluginDescriptorTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
package cc.unitmesh.ide.javascript

import org.junit.Test
import javax.xml.XMLConstants
import javax.xml.parsers.DocumentBuilderFactory
import kotlin.test.assertTrue

class JavaScriptPluginDescriptorTest {
@Test
fun testDescriptorDeclaresRequiredJavaScriptV2Modules() {
val dependencies = parseDependencies("/cc.unitmesh.javascript.xml")

assertTrue("intellij.javascript.backend" in dependencies, "Missing required module: intellij.javascript.backend")
assertTrue("intellij.javascript.common" in dependencies, "Missing required module: intellij.javascript.common")
assertTrue("intellij.javascript.psi.impl" in dependencies, "Missing required module: intellij.javascript.psi.impl")
assertTrue("intellij.javascript.testing" in dependencies, "Missing required module: intellij.javascript.testing")
}

private fun parseDependencies(resourcePath: String): Set<String> {
val stream = checkNotNull(javaClass.getResourceAsStream(resourcePath)) {
"Missing resource: $resourcePath"
}

stream.use { input ->
val document = documentBuilderFactory().newDocumentBuilder().parse(input)
return document.getElementsByTagName("module")
.let { nodes -> (0 until nodes.length).map { index -> nodes.item(index) } }
.mapNotNull { it.attributes?.getNamedItem("name")?.nodeValue }
.toSet()
}
}

private fun documentBuilderFactory(): DocumentBuilderFactory {
return DocumentBuilderFactory.newInstance().apply {
setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true)
setFeature("http://apache.org/xml/features/disallow-doctype-decl", true)
setExpandEntityReferences(false)
}
}
}