fix invalid status on longpoll window timeout

Author: SteffenDE

lib/phoenix/transports/long_poll.ex

@@ -88,7 +88,7 @@ defmodule Phoenix.Transports.LongPoll do
               body
               |> String.splitter(["\n", "\r\n"])
               # |> Stream.take(@max_poll_batch_size)
-              |> Enum.find(fn part ->
+              |> Enum.find_value(fn part ->
                 msg =
                   case part do
                     "[" <> _ = txt -> {txt, :text}

test/phoenix/integration/long_poll_channels_test.exs

@@ -115,6 +115,22 @@ defmodule Phoenix.Integration.LongPollChannelsTest do
     end
   end
 
+  defmodule SlowSocket do
+    @behaviour Phoenix.Socket.Transport
+
+    def child_spec(_opts), do: :ignore
+    def connect(_), do: {:ok, %{}}
+    def init(state), do: {:ok, state}
+
+    def handle_in(_message, state) do
+      Process.sleep(:infinity)
+      {:ok, state}
+    end
+
+    def handle_info(_message, state), do: {:ok, state}
+    def terminate(_reason, _state), do: :ok
+  end
+
   defmodule Endpoint do
     use Phoenix.Endpoint, otp_app: :phoenix
 
@@ -139,6 +155,13 @@ defmodule Phoenix.Integration.LongPollChannelsTest do
         check_origin: ["//example.com"],
         connect_info: [:trace_context_headers, :x_headers, :peer_data, :uri]
       ]
+
+    socket "/ws/slow", SlowSocket,
+      longpoll: [
+        window_ms: 100,
+        pubsub_timeout_ms: 200,
+        check_origin: ["//example.com"]
+      ]
   end
 
   setup %{adapter: adapter} do
@@ -597,6 +620,28 @@ defmodule Phoenix.Integration.LongPollChannelsTest do
           assert resp.body["status"] == 410
         end
       end
+
+      test "publish responds with 408 when transport_dispatch times out" do
+        resp = poll(:get, "/ws/slow", "2.0.0", %{}, nil)
+        assert resp.body["status"] == 410
+        assert resp.status == 200
+
+        session = Map.take(resp.body, ["token"])
+
+        resp =
+          poll(:post, "/ws/slow", "2.0.0", session, [
+            %{
+              "topic" => "room:lobby",
+              "event" => "ping",
+              "ref" => "1",
+              "join_ref" => "1",
+              "payload" => %{}
+            }
+          ])
+
+        assert resp.status == 200
+        assert resp.body["status"] == 408
+      end
     end
 
     for {serializer, vsn, join_ref} <- [