undo select change

When working on #4227
I noticed that the code set readOnly for selects, but selects don't have
a readOnly property. I changed the code to disable them instead.

Since I'm not fully convinced that this does not negatively affect
form submissions in some circumstances, I'm reverting that change for now.

(disabled form elements are not part of a form payload)

Author: SteffenDE

assets/js/phoenix_live_view/view.ts

@@ -1958,14 +1958,10 @@ export default class View {
     const filterInput = (el): el is HTMLInputElement | HTMLTextAreaElement =>
       ["INPUT", "TEXTAREA"].includes(el.tagName);
 
-    const filterSelects = (el): el is HTMLSelectElement =>
-      el.tagName === "SELECT";
-
     const formElements = Array.from(formEl.elements);
     const disables = formElements.filter(filterDisables);
     const buttons = formElements.filter(filterButton).filter(filterIgnored);
     const inputs = formElements.filter(filterInput).filter(filterIgnored);
-    const selects = formElements.filter(filterSelects).filter(filterIgnored);
 
     buttons.forEach((button) => {
       button.setAttribute(PHX_DISABLED, button.disabled.toString());
@@ -1979,14 +1975,9 @@ export default class View {
         input.disabled = true;
       }
     });
-    selects.forEach((select) => {
-      select.setAttribute(PHX_DISABLED, select.disabled.toString());
-      select.disabled = true;
-    });
     const formEls = disables
       .concat(buttons)
       .concat(inputs)
-      .concat(selects)
       .map((el) => {
         return { el, loading: true, lock: true };
       });